Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconvenient default hotkey mapping activation #2723

Closed
koral-- opened this issue Jun 21, 2017 · 21 comments

Comments

@koral--
Copy link

commented Jun 21, 2017

Describe the issue

When uBlock has been updated to v 1.13.0 and keyboard layout using right Alt is set then browser (Chrome) enters weird state silently.
In some keyboard layouts eg. Polish (programmer) right Alt/Option is used to type letters with diacritics e.g. Alt+Z = ż.
After update to 1.13.0 this feature had been broken and users need to manually remove/change shortcuts.

Possible solutions:

  1. Use left Alt instead of right one (if possible from plugin level)
  2. Change Alt to something else
  3. At least do not enable conflicting hotkey silently on extension update

Steps for anyone to reproduce the issue

  1. Have some keyboard layout set which uses right Alt key (eg. Polish programmer)
  2. Update extension to v 1.13.0
  3. Try to type e.g. ż
  4. Element zapper mode is activated instead

Your settings

  • OS/version: macOS/10.12.5
  • Browser/version: Chrome/58.0.3029.110
  • uBlock Origin version: 1.13.0
@mliese

This comment has been minimized.

Copy link

commented Jun 21, 2017

OS/version: macOS/10.12.5
Browser/version: Chrome/58.0.3029.110
uBlock Origin version: 1.13.0

Alt+L is now opening a new tab to "logger-ui.html"
Alt+L is normally "@".

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

Would Ctrl-Shift instead of Alt work better?

I wish this had been found before release, apparently not many people are testing the dev build.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

Ctrl-Shift does not work on my side. I will just remove the suggested defaults and let users configure themselves and use whatever works for them.

@gorhill gorhill closed this in d22f4b8 Jun 21, 2017

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

Meanwhile, those key bindings can be changed in Chrome, go to chome://extensions, scroll down and click "Keyboard shortcuts" at the bottom of the page.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

I would like to know if the issue reported here also affects Firefox.

@gorhill gorhill reopened this Jun 21, 2017

@gwarser

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

No problem with Polish layout in Linux Mint 17.3, Fx nightly

@dhigh88

This comment has been minimized.

Copy link

commented Jun 21, 2017

@gorhill Hello sir, sorry I know this isn't the place to report another issue but is it possible you or any other staff can please assist me in the ublock edge issue page? Anytime I ask for help I haven't had no assistance from nikrolls.

@gwarser

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

I also checked Win XP, Fx 52.2esr, UBO 1.13.0. Looks almost good. Left alt+z brings main Fx menu. Picker mode and logger works. I can type żźł (right alt + zxl).

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

@dhigh88

Hello sir, sorry I know this isn't the place to report another issue but is it possible you or any other staff can please assist me in the ublock edge issue page? Anytime I ask for help I haven't had no assistance from nikrolls.

This?

Looks like a filter list issue to me, should not be opened on uBO Edge's issue tracker, but rather at https://github.com/uBlockOrigin/uAssets.

That the issue occurs only with Edge does not make it less a filter list issue, sites will commonly sniff user-agent info and execute specific code path as a result. So always assume filter list issue and report where appropriate, the filter list maintainers will figure out if there is really an issue in uBO itself.

Also, there is no "staff" with uBO, only volunteers contributing on their free time.

@nietaki

This comment has been minimized.

Copy link

commented Jun 21, 2017

I just run into the same problem (Chrome on OSX) and believe me, for any Polish layout user it's an extremely annoying thing to encounter. I was on the verge of ditching uBlock Origin until I read @gorhill's comment :)

I'd argue that setting any shortcuts for uBlock origin's functionality by default is overkill. I consider myself a Chrome poweruser but I never felt the need to have any shortcut for "uBlock Origin logs". While it's a good thing to be able to provide a shortcut for those functionalities, I think for the vast majority of users setting up any default shortcuts will cause more annoyance than it would be helpful.

@gwarser

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

UBO 1.13.2 in Vivaldi (stable) - manually set shortcuts not work (Probably Vivaldi fault #2719 #953?)

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

For any issue affecting Vivaldi or any of the Chromium-based browsers no covered here (Chromium, Chrome, Opera), a maintainer will have to step up and fork to deal with issues specific to the platform as was done with Edge and Safari.

@indywidualny

This comment has been minimized.

Copy link

commented Jun 21, 2017

How to disable shortcuts completely? I cannot use my keyboard normally now.

Sorry. I didn't notice I can configure it at extensions page :)

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

I added details on how to do this in Release notes:

For those already affected by the issue, the suggested shortcuts were already added and won't be removed with this update. You will have to remove or re-assign yourself by clicking "Keyboard shortcuts" link in the page chrome://extensions -- the link is at the bottom of the page.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 21, 2017

@bershan2 If the shortcuts have been added by 1.13.0, I don't think they will be removed with 1.13.2, what has been removed is the suggested shortcuts in 1.13.2.

@dhigh88

This comment has been minimized.

Copy link

commented Jun 21, 2017

@gorhill Appreciated the response. I've submitted it to the requested page.

@gorhill gorhill closed this in ca45ade Jun 22, 2017

@gorhill

This comment has been minimized.

Copy link
Owner

commented Jun 22, 2017

I also modified the code for Firefox: just like with Chromium, users will have to assign the shortcut themselves. By default, there are no shortcuts.

@happysurf

This comment has been minimized.

Copy link

commented Sep 9, 2017

The suggested shortcuts like alt-X or accel-X doesn't work on my Firefox 56b10 + UBO 1.14.9b0 on Windows.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2017

@happysurf #2870.

@F-DK

This comment has been minimized.

Copy link

commented Oct 18, 2017

How is this issue closed??

This extremely annoying keyboard shortcut mapping is still true:
#2723 (comment)

Alt+L is now opening a new tab to "logger-ui.html"
Alt+L is normally "@".

In consequence one cannot write @ in Chrome at all 😭

OS/version: macOS/10.12.6
Browser/version: Chrome/61.0.3163.100
uBlock Origin version: 1.14.12

@F-DK

This comment has been minimized.

Copy link

commented Oct 18, 2017

Okay, after further googling I found this super hidden feature in Chrome. Thanks @receter!

uBlock-LLC/uBlock#1688 (comment)

Solution: Go to chrome://extensions/ , scroll down to the bottom, click Keyboard shortcuts, remove the shortcut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.