Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider changing the popup icon's cross sign. #2836

Closed
sharethewisdom opened this issue Aug 1, 2017 · 6 comments

Comments

@sharethewisdom
Copy link

commented Aug 1, 2017

Aren't the VECTOR OR CROSS PRODUCT or N-ARY TIMES OPERATOR variants more widely available than MULTIPLICATION X, which is currently used to style the popup's icon overlays?

#extraTools > span.on > span:last-of-type:after {
  content: '\2715';
}

using

uBlock Origin 1.13.8
Chromium Version 59.0.3071.115 (Developer Build) (64-bit)
Linux arch 4.11.9-1-ARCH #1 SMP PREEMPT Wed Jul 5 18:23:08 CEST 2017 x86_64 GNU/Linux

...with the core fonts from Microsoft available for Chromium:

Andale Mono, Arial, Arial Black, Comic Sans MS, Courier, Courier New, Georgia, Helvetica, Impact, Times, Times New Roman, Trebuchet MS, Verdana, Wingdings 2, Wingdings 3 (via javascript)

While I do not see U+2715 (✕),
both U+2A2F (⨯) and U+2A09 (⨉) are available in all of the fonts Chromium presents to me.

I'm aware that due to its sandbox, Chromium does not fully integrate with fontconfig/GTK/Pango/X/etc. If there's a way for me to replace that symbol with a complementary font, please let me know.

@gorhill

This comment has been minimized.

Copy link
Owner

commented Aug 1, 2017

Actually, I was considering it.

I was planning to import the solution I used in uBO-Scope: a simple svg element.

@sharethewisdom

This comment has been minimized.

Copy link
Author

commented Aug 1, 2017

👍
I'm glad to see you take a simple svg approach. I often see icons rendered on canvas. That fails when starting chromium with --enable-potentially-annoying-security-features with a 'getImageData' error. Which is indeed, annoying.

@BilBg

This comment has been minimized.

Copy link

commented Aug 4, 2017

While I do not see U+2715 (✕),
both U+2A2F (⨯) and U+2A09 (⨉) are available in all of the fonts Chromium presents to me

I see U+2715 (✕) and U+2A09 (⨉) as (X) but U+2A2F (⨯) as square (i.e. non-existent) on this page in Chromium 48 on Windows XP

@sharethewisdom

This comment has been minimized.

Copy link
Author

commented Aug 4, 2017

@BilBg thanks. Beware the outdated browser. Out of curiosity: what's your standard font? (chrome://settings/fonts) Could you list the system fonts available to chromium? You can test the uniqueness of your browser's settings, which lists System Fonts, and a uniqueness figure.

In my case, only one in 283.59 browsers tested supposedly have these fonts. Many Windows users have a huge list of fonts there. Anyway, since this cross will likely be replaced with svg, it doesn't matter.

@BilBg

This comment has been minimized.

Copy link

commented Aug 5, 2017

Beware the outdated browser

The latest possible is Slimjet 10.0.13.0 (Chromium 50) (Portable)
(7-8 browsers here, including the old Opera 12.16 and Tor Browser 6.5.2 which is the only new-enough)

Out of curiosity: what's your standard font?

Times New Roman

Could you list the system fonts available to chromium?

They are about 75

@gwarser

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2017

On android 4.4.2 lg l65 I only see U+2715 (✕)

@gorhill gorhill closed this in 7291227 Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.