This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
Permalink
Cannot retrieve contributors at this time
Name already in use
A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?
csrf/store_legacy_test.go
Go to fileThis commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
163 lines (127 sloc)
3.95 KB
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//go:build !go1.11 | |
// +build !go1.11 | |
// file for compatibility with go versions prior to 1.11 | |
package csrf | |
import ( | |
"errors" | |
"fmt" | |
"net/http" | |
"net/http/httptest" | |
"strings" | |
"testing" | |
"github.com/gorilla/securecookie" | |
) | |
// Check store implementations | |
var _ store = &cookieStore{} | |
// brokenSaveStore is a CSRF store that cannot, well, save. | |
type brokenSaveStore struct { | |
store | |
} | |
func (bs *brokenSaveStore) Get(*http.Request) ([]byte, error) { | |
// Generate an invalid token so we can progress to our Save method | |
return generateRandomBytes(24) | |
} | |
func (bs *brokenSaveStore) Save(realToken []byte, w http.ResponseWriter) error { | |
return errors.New("test error") | |
} | |
// Tests for failure if the middleware can't save to the Store. | |
func TestStoreCannotSave(t *testing.T) { | |
s := http.NewServeMux() | |
bs := &brokenSaveStore{} | |
s.HandleFunc("/", testHandler) | |
p := Protect(testKey, setStore(bs))(s) | |
r, err := http.NewRequest("GET", "/", nil) | |
if err != nil { | |
t.Fatal(err) | |
} | |
rr := httptest.NewRecorder() | |
p.ServeHTTP(rr, r) | |
if rr.Code != http.StatusForbidden { | |
t.Fatalf("broken store did not set an error status: got %v want %v", | |
rr.Code, http.StatusForbidden) | |
} | |
if c := rr.Header().Get("Set-Cookie"); c != "" { | |
t.Fatalf("broken store incorrectly set a cookie: got %v want %v", | |
c, "") | |
} | |
} | |
// TestCookieDecode tests that an invalid cookie store returns a decoding error. | |
func TestCookieDecode(t *testing.T) { | |
r, err := http.NewRequest("GET", "/", nil) | |
if err != nil { | |
t.Fatal(err) | |
} | |
var age = 3600 | |
// Test with a nil hash key | |
sc := securecookie.New(nil, nil) | |
sc.MaxAge(age) | |
st := &cookieStore{cookieName, age, true, true, "", "", sc, SameSiteDefaultMode} | |
// Set a fake cookie value so r.Cookie passes. | |
r.Header.Set("Cookie", fmt.Sprintf("%s=%s", cookieName, "notacookie")) | |
_, err = st.Get(r) | |
if err == nil { | |
t.Fatal("cookiestore did not report an invalid hashkey on decode") | |
} | |
} | |
// TestCookieEncode tests that an invalid cookie store returns an encoding error. | |
func TestCookieEncode(t *testing.T) { | |
var age = 3600 | |
// Test with a nil hash key | |
sc := securecookie.New(nil, nil) | |
sc.MaxAge(age) | |
st := &cookieStore{cookieName, age, true, true, "", "", sc, SameSiteDefaultMode} | |
rr := httptest.NewRecorder() | |
err := st.Save(nil, rr) | |
if err == nil { | |
t.Fatal("cookiestore did not report an invalid hashkey on encode") | |
} | |
} | |
// TestMaxAgeZero tests that setting MaxAge(0) does not set the Expires | |
// attribute on the cookie. | |
func TestMaxAgeZero(t *testing.T) { | |
var age = 0 | |
s := http.NewServeMux() | |
s.HandleFunc("/", testHandler) | |
r, err := http.NewRequest("GET", "/", nil) | |
if err != nil { | |
t.Fatal(err) | |
} | |
rr := httptest.NewRecorder() | |
p := Protect(testKey, MaxAge(age))(s) | |
p.ServeHTTP(rr, r) | |
if rr.Code != http.StatusOK { | |
t.Fatalf("middleware failed to pass to the next handler: got %v want %v", | |
rr.Code, http.StatusOK) | |
} | |
if rr.Header().Get("Set-Cookie") == "" { | |
t.Fatalf("cookie not set: got %q", rr.Header().Get("Set-Cookie")) | |
} | |
cookie := rr.Header().Get("Set-Cookie") | |
if !strings.Contains(cookie, "HttpOnly") || strings.Contains(cookie, "Expires") { | |
t.Fatalf("cookie incorrectly has the Expires attribute set: got %q", cookie) | |
} | |
} | |
// TestSameSizeSet tests that setting SameSite Option does not set the SameSite | |
// attribute on the cookie in legacy systems. | |
func TestSameSizeSet(t *testing.T) { | |
s := http.NewServeMux() | |
s.HandleFunc("/", testHandler) | |
r, err := http.NewRequest("GET", "/", nil) | |
if err != nil { | |
t.Fatal(err) | |
} | |
rr := httptest.NewRecorder() | |
p := Protect(testKey, SameSite(SameSiteStrictMode))(s) | |
p.ServeHTTP(rr, r) | |
if rr.Code != http.StatusOK { | |
t.Fatalf("middleware failed to pass to the next handler: got %v want %v", | |
rr.Code, http.StatusOK) | |
} | |
if rr.Header().Get("Set-Cookie") == "" { | |
t.Fatalf("cookie not set: got %q", rr.Header().Get("Set-Cookie")) | |
} | |
cookie := rr.Header().Get("Set-Cookie") | |
if strings.Contains(cookie, "SameSite") { | |
t.Fatalf("cookie incorrectly has the SameSite attribute set: got %q", cookie) | |
} | |
} |