Conversation
Adding proper support for Enclosure and and Image tags, which didn't seem to generate properly (might have been a bug on my end but I'm not sure).
fix RSS image when no Image is mentioned in the Feed
kisielk
left a comment
kisielk
left a comment
There was a problem hiding this comment.
Looking good, just a bit of clean up needed. Also please fix the gofmt failure in Travis.
README.md
Outdated
| @@ -1,9 +1,12 @@ | |||
| ## gorilla/feeds | |||
| [](https://godoc.org/github.com/gorilla/feeds) [](https://travis-ci.org/gorilla/feeds) | |||
| ## gmemstr/feeds | |||
There was a problem hiding this comment.
Probably shouldn’t change this...
README.md
Outdated
| feeds is a web feed generator library for generating RSS, Atom and JSON feeds from Go | ||
| applications. | ||
|
|
||
| This is a fork by gmemstr which aims to make feeds more "podcast-centered". Essentially making |
atom.go
Outdated
| i.Link.Rel = "enclosure" | ||
| x.Link = &AtomLink{Href: i.Link.Href, Rel: i.Link.Rel, Type: i.Link.Type, Length: i.Link.Length} | ||
| if i.Enclosure != nil && link_rel != "enclosure" { | ||
| // if intLength, err := strconv.ParseInt(i.Enclosure.Length, 10, 64); err == nil && intLength > 0 { |
There was a problem hiding this comment.
Commented or code should be removed
rss.go
Outdated
| item.Enclosure = &RssEnclosure{Url: i.Link.Href, Type: i.Link.Type, Length: i.Link.Length} | ||
| // Define a closure | ||
| if i.Enclosure != nil && i.Enclosure.Type != "" && i.Enclosure.Length != "" { | ||
| // if intLength, err := strconv.ParseInt(i.Enclosure.Length, 10, 64); err == nil && intLength > 0 { |
|
will do shortly - just headee home now. didn't actually expect to make this PR but thanks to florentheobin for the fixed. |
|
Thanks. This changes the API, but I think if we tag a release before, we can probably merge this without feeling too guilty. @elithrar any thoughts on this one? |
|
Agree RE: tagging. If we tag a major version before / after it should be
OK.
…On Wed, Sep 27, 2017 at 9:51 PM Kamil Kisiel ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABIcLEZRLvckRC5GtPl9VymfUlqu17yks5smyXrgaJpZM4Pl4QE>
.
|
|
Bump for this, just saw mux got a new release. Is there anything else I should add to this PR before? |
|
I'm ok with it going ahead. @elithrar should we tag 1.0 for the current version of the code, and then 1.1 after merging this? though that doesn't really give people an opportunity to lock to 1.0 in the meantime so not sure if it's worth it since their code will break anyway. Maybe we should just do the bandaid pull approach and merge this and then tag 1.0? |
|
Let’s do that - just tag 1.0 after this. Neither approach is ideal, but I
agree that few people are probably locking to a version as-is.
Will get better in future!
…On Tue, Nov 7, 2017 at 8:56 AM Kamil Kisiel ***@***.***> wrote:
I'm ok with it going ahead. @elithrar <https://github.com/elithrar>
should we tag 1.0 for the current version of the code, and then 1.1 after
merging this? though that doesn't really give people an opportunity to lock
to 1.0 in the meantime so not sure if it's worth it since their code will
break anyway. Maybe we should just do the bandaid pull approach and merge
this and then tag 1.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABIcLa5qsRyKgTQ4po5hGnpSjKpEJRYks5s0IuygaJpZM4Pl4QE>
.
|
|
v1.0.0 tagged: https://github.com/gorilla/feeds/releases/tag/v1.0.0 |
|
Thanks @gmemstr and @florenthobein for contributing this! |
4 participants
After some work from myself and florentheobin we've gotten image support for feeds fully done, including tests.