Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues (docs) #370

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
3 participants
@elithrar
Copy link
Member

elithrar commented May 1, 2018

No description provided.

@elithrar elithrar self-assigned this May 1, 2018

@elithrar elithrar merged commit ded0c29 into master May 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@elithrar elithrar deleted the elithrar/linter-fixes branch May 1, 2018

@@ -43,6 +43,8 @@ type Route struct {
buildVarsFunc BuildVarsFunc
}

// SkipClean bypasses cleaning the path, which includes removing duplicate
// slashes and URL encoding.

This comment has been minimized.

Copy link
@kisielk

kisielk May 1, 2018

Member

That's actually not what this function does. It reports whether the SkipClean option is enabled for this route.

@elithrar

This comment has been minimized.

Copy link
Member Author

elithrar commented May 1, 2018

@@ -12,7 +12,7 @@ type middleware interface {
Middleware(handler http.Handler) http.Handler
}

// MiddlewareFunc also implements the middleware interface.
// Middleware also implements the middleware interface.

This comment has been minimized.

Copy link
@dmitshur

dmitshur May 4, 2018

Contributor

Maybe it'd be a good idea to remove the word "also":

// Middleware implements the middleware interface.

When reading documentation for this method, it might be confusing. "Middleware also implements it? In addition to what?"

@@ -13,8 +13,11 @@ import (
)

var (
// ErrMethodMismatch is returned when the error in the request does not match

This comment has been minimized.

Copy link
@dmitshur

dmitshur May 4, 2018

Contributor

I suspect "when the error in the request" should be "when the method in the request".

@elithrar

This comment has been minimized.

Copy link
Member Author

elithrar commented May 13, 2018

Fixes in #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.