Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/subrouter custom methodNotAllowed handler returning 404 (#509)

Conversation

jonasdebeukelaer
Copy link
Contributor

@jonasdebeukelaer jonasdebeukelaer commented Aug 20, 2019

Fixes #509

Summary of Changes

  1. check new handler not nil before discarding MethodNotAllowed error
  2. add unit test

@jonasdebeukelaer jonasdebeukelaer force-pushed the bugfix/subrouter-custom-methodNotAllowed-handler-returning-404 branch from a9ce43a to c4781b8 Compare Aug 20, 2019
Copy link
Member

@elithrar elithrar left a comment

Thanks for this - just one minor nit.

mux_test.go Outdated Show resolved Hide resolved
@jonasdebeukelaer jonasdebeukelaer force-pushed the bugfix/subrouter-custom-methodNotAllowed-handler-returning-404 branch from c4781b8 to db220ca Compare Aug 20, 2019
@jonasdebeukelaer
Copy link
Contributor Author

jonasdebeukelaer commented Aug 24, 2019

happy to merge this @elithrar ?

@elithrar
Copy link
Member

elithrar commented Aug 24, 2019

@elithrar elithrar self-assigned this Aug 26, 2019
@elithrar elithrar added the bug label Aug 26, 2019
@elithrar elithrar merged commit 9536e40 into gorilla:master Aug 26, 2019
1 check passed
@elithrar
Copy link
Member

elithrar commented Aug 26, 2019

Merged - thanks @jonasdebeukelaer!

@jonasdebeukelaer jonasdebeukelaer deleted the bugfix/subrouter-custom-methodNotAllowed-handler-returning-404 branch Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants