Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed golint warnings

Merged
merged 1 commit into from Nov 21, 2019
Merged

Fixed golint warnings #526

merged 1 commit into from Nov 21, 2019

Conversation

KosToZyB
Copy link
Contributor

@KosToZyB KosToZyB commented Oct 24, 2019

Fixed:

  1. mux.go:366:5: error var SkipRouter should have name of the form ErrFoo
  2. regexp.go:184:9: if block ends with a return statement, so drop this else and outdent its block

Copy link
Member

@elithrar elithrar left a comment

Can’t accept changes that would break the public API.

mux.go Outdated
// router that walk is about to descend down to should be skipped.
var SkipRouter = errors.New("skip this router")
var ErrSkipRouter = errors.New("skip this router")
Copy link
Member

@elithrar elithrar Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. That golint complains is unfortunate, but this predates golint.

Copy link
Contributor Author

@KosToZyB KosToZyB Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@elithrar elithrar self-assigned this Nov 21, 2019
@elithrar elithrar merged commit 49c0148 into gorilla:master Nov 21, 2019
1 check passed
@elithrar
Copy link
Member

elithrar commented Nov 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants