Export convertors

[themihai]

Is there any reason not to export convertors? I need to decode a payload which is composed either by structs or /and non-struct types (e.g. map[string]float64). Currently the decoder errors out if the destination is not a struct so I've forked the repo and just exported convertors.

[kisielk]

It's an implementation detail, so best not to export it. Does RegisterConverter not work for your case?

[themihai]

I don't think RegisterConverter helps. Decode errors out[0] if the value provided is not struct, isn't it? An alternative would be to provide a new function DecodeValue(valStr string, kind reflect.Kind)reflect.Value which decodes a single value.

[0] https://github.com/gorilla/schema/blob/master/decoder.go#L72

[kisielk]

Hm maybe I'm not clear on what you are looking for. You want to decode the values in to a map directly, one which isn't a member of a struct? I'm not sure why you would even need the schema package for that.

[themihai]

I need to unmarshal a map[string][]string into two variables . One is a struct and the other is of a type supported by schema (bool, int etc) but unknown at compile time. So I use schema.Decoder to unmarshal the map into the struct and then I need to parse the value of the 2nd variable(I know its key) thus the reason why I need the Convertors/parsing function.
Another option is to merge the unknown variable with the struct in a map using reflect (make a new map, copy all the struct fields as keys -> pointers) but Decoder doesn't support maps either(I fail to see the reason why).

    form := r.FormValue()
   var1 := schema.NewDecoder().Decode(val.Interface(), form)

   var2 := schema.Convertors[paramTyp.Elem().Kind()](form.Get(paramName))

[themihai]

Shortly said schema package has an internal function(convertors) which marshals a string into various types/kinds and I need just that thus the proposal to export it.

[stale]

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.