problem with svn and "@" character in folder name #10

Closed
orizens opened this Issue Jul 4, 2012 · 2 comments

Comments

Projects
None yet
2 participants

orizens commented Jul 4, 2012

when a file is under a directory which has a name with "@" character, the plugin stops working: it doesn't show the change markers, diff operation says that the file is not under svn repository.
"@" character in svn is used for revisions - thus - it's a known issue.

Suggested and Working solution

suggested by user https://github.com/eladyarkoni:
the "run" method in class "DiffCommand", should be:

def run(self, edit):
    vcs = get_vcs(self.get_working_dir())
    filename = os.path.basename(self.view.file_name())
    get_command = getattr(self, '{0}_diff_command'.format(vcs['name']),None)
    if get_command: self.run_command(get_command(filename), self.diff_done)

By my testing and daily work, this solution plays nicely with svn and doesn't break mercurial.

gornostal pushed a commit that referenced this issue Jul 4, 2012

Owner

gornostal commented Jul 4, 2012

Thanks for the solution.
Looks like it works.

@gornostal gornostal closed this Jul 4, 2012

orizens commented Jul 4, 2012

great - thanks for the plugin.
i'll post a suggestion too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment