Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace (un)serialize with json_encode/json_decode #29

Merged
merged 1 commit into from Aug 13, 2019

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jul 29, 2019

GOsa currently uses unserialize to restore filter settings from a cookie. Since this cookie is supplied by the client, authenticated users can pass arbitrary content to unserialized, which opens GOsa up to a potential PHP object injection.

This PR protects against such issues by switching to the safe json_decode method.

@fmeum
Copy link
Contributor Author

fmeum commented Aug 16, 2019

The original fix does not work as intended, please follow up with #31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants