create helpers for using goss as a package #548
Conversation
|
https://github.com/aelsabbahy/goss/blob/d739600cb55b13957a9424fc8b9e31087917ab1c/goss_test.go#L24-L84 demonstrates using add/validate |
This also merges the RuntimeConfig with Config as these had overlapping uses, simplify some timeout handling and surpress output when adding resources to a goss file This stops short of overhauling all std output and instead just focus on the things package users are likely to want to do - programatically add resources and validate them. Additionally a new output format 'structured' is added that has a matching data type that defines it's output which makes it easier to use the result sets from goss programatically
|
@aelsabbahy good to go on this |
|
I've been traveling for a week so been off the radar, back now, is there anything else left for me to do here? |
|
Appears this PR is now gone out of date due to non attention, am I just expected to keep rebasing and rebasing while you keep merging other PRs and not this one? With such a large piece of the code base being touched it's worth getting this one in to limit the knock on effect of continuously having to keep updating/rebasing/fixing this one |
There was a problem hiding this comment.
@ripienaar I am very sorry that no one has taken a look at your PR yet! It's shameful that we dropped the ball there.
But I have taken a look a now and everything seems to be perfectly fine it's impressive work.
|
Hello, no rebase is necessary. I've been making sure I don't merge anything that conflicts with this PR as there's a lot of changes here. Smaller changes I've merged in to cut a release. This will be the first PR merged if there's any conflicting PRs |
|
thanks, would be good to get this merged for me as I can then continue to work on the what I need this for based on your master. |
|
Thanks for this. Awesome set of changes so far. |
This also merges the RuntimeConfig with Config as these had overlapping uses, simplify some timeout handling and surpress output when adding resources to a goss file This stops short of overhauling all std output and instead just focus on the things package users are likely to want to do - programatically add resources and validate them. Additionally a new output format 'structured' is added that has a matching data type that defines it's output which makes it easier to use the result sets from goss programatically Co-authored-by: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com>
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This creates a way to make a goss Config programatically with defaults
suitable to use as a package.
This also merges the RuntimeConfig with Config as these had overlapping
uses, simplify some timeout handling and optionally surpress output when
adding resources to a goss file
This stops short of overhauling all std output and instead just focus
on the things package users are likely to want to do - programatically
add resources and validate them.
Additionally a new output format 'structured' is added that has a
matching data type that defines it's output which makes it easier
to use the result sets from goss programatically, this is handy when
one wants to write tooling to process CI output from goss in go