Implement Historic Price API End Point #8

namantw · 2018-01-17T12:11:09Z

Fixes : #4

mubaris · 2018-01-17T13:47:38Z

examples/example.go

@@ -14,4 +14,17 @@ func main() {

 	USD, GBP, EUR := coindesk.CurrentPrice()
 	fmt.Println(USD, GBP, EUR)
+
+	var historyPrice []Price


Don't declare and initialize in separate line.

historyPrice := coindesk.HistoryPrice("2013-09-01", "2013-09-05")

This will be good.

OR

Instead of []Price, it should be []coindesk.Price

mubaris · 2018-01-17T13:52:41Z

coindesk.go

 )

+type Price struct {
+	date time.Time


Rename date and price to Date and Price, so that user can access it. Change wherever you mentioned it and update example.

Read the Travis CI details.

price --> Price date --> Date

namantw · 2018-01-17T18:37:09Z

@mubaris please review

namantw and others added 2 commits January 17, 2018 17:40

Implement Historic Price API End Point

554b3a7

Update example.go

e51d3ca

mubaris approved these changes Jan 17, 2018

View reviewed changes

mubaris requested changes Jan 17, 2018

View reviewed changes

namantw added 2 commits January 18, 2018 00:03

Made requested changes

5040198

Made requested changes

0869361

price --> Price date --> Date

mubaris approved these changes Jan 18, 2018

View reviewed changes

mubaris merged commit 15f802b into gostudent:master Jan 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Historic Price API End Point #8

Implement Historic Price API End Point #8

namantw commented Jan 17, 2018

mubaris Jan 17, 2018

mubaris Jan 17, 2018

namantw commented Jan 17, 2018

Implement Historic Price API End Point #8

Implement Historic Price API End Point #8

Conversation

namantw commented Jan 17, 2018

mubaris Jan 17, 2018

Choose a reason for hiding this comment

mubaris Jan 17, 2018

Choose a reason for hiding this comment

namantw commented Jan 17, 2018