Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions #4

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Fix GitHub Actions #4

merged 6 commits into from
Aug 10, 2023

Conversation

jlnr
Copy link
Member

@jlnr jlnr commented Aug 10, 2023

Turns out that the syntax was broken (again) in #3. Sigh, it looked like the tests were green in the UI. Really confusing...

Let's see if this works.

@jlnr
Copy link
Member Author

jlnr commented Aug 10, 2023

@Chadowo I have sent you an invitation to be a maintainer of this repository. Then you can also directly create branches in gosu/chingu instead of Chadowo/chingu, if you prefer so.

@jlnr
Copy link
Member Author

jlnr commented Aug 10, 2023

Okay, now it fails in the macOS network spec that was also failing locally.

@jlnr jlnr disabled auto-merge August 10, 2023 12:58
@jlnr jlnr enabled auto-merge (squash) August 10, 2023 12:58
spec/chingu/network_spec.rb Outdated Show resolved Hide resolved
@Chadowo
Copy link
Collaborator

Chadowo commented Aug 10, 2023

Hey there, I need to thank you first for being so helpful :D! anyhow thanks for the help with networking, its somewhat puzzling for me because I don't have much experience networking in videogames, so I appreciate it a lot.

@Chadowo I have sent you an invitation to be a maintainer of this repository. Then you can also directly create branches in gosu/chingu instead of Chadowo/chingu, if you prefer so.

I'll accept it 👍

@Chadowo Chadowo self-assigned this Aug 10, 2023
Copy link
Collaborator

@Chadowo Chadowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's looking good and ready to merge if you will.

@jlnr jlnr merged commit c977859 into master Aug 10, 2023
6 checks passed
@jlnr jlnr deleted the fix-actions branch August 10, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants