Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): drop request on context deadline #324

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

tie
Copy link
Contributor

@tie tie commented May 7, 2021

This change makes the RPC engine drop the request when parent context reaches deadline.
That is, before this change a deadline from context.WithTimeout would not drop the request.

This change makes the RPC engine drop the request when parent context reaches deadline.
That is, before this change a deadline from context.WithTimeout would not drop the request.
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #324 (4b63efc) into main (c7e01d2) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   68.78%   68.95%   +0.17%     
==========================================
  Files         294      294              
  Lines        9246     9246              
==========================================
+ Hits         6360     6376      +16     
+ Misses       2280     2266      -14     
+ Partials      606      604       -2     
Impacted Files Coverage Δ
internal/rpc/engine.go 77.60% <100.00%> (+5.59%) ⬆️
internal/mtproto/read.go 48.38% <0.00%> (-2.16%) ⬇️
internal/proto/codec/intermediate.go 81.57% <0.00%> (+5.26%) ⬆️
internal/mtproto/rpc.go 64.86% <0.00%> (+24.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e01d2...4b63efc. Read the comment docs.

@ernado ernado merged commit 80069da into gotd:main May 7, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants