Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): full codec fix race condition #325

Merged
merged 1 commit into from May 7, 2021

Conversation

shadowspore
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #325 (3bf28ef) into main (49234a0) will decrease coverage by 0.36%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   68.91%   68.55%   -0.37%     
==========================================
  Files         294      294              
  Lines        9275     9273       -2     
==========================================
- Hits         6392     6357      -35     
- Misses       2281     2309      +28     
- Partials      602      607       +5     
Impacted Files Coverage Δ
internal/proto/codec/full.go 68.88% <50.00%> (-1.33%) ⬇️
internal/mtproto/rpc.go 40.54% <0.00%> (-24.33%) ⬇️
internal/rpc/options.go 90.00% <0.00%> (-10.00%) ⬇️
internal/pool/pool.go 59.12% <0.00%> (-9.49%) ⬇️
internal/rpc/engine.go 72.00% <0.00%> (-6.41%) ⬇️
internal/mtproto/read.go 50.53% <0.00%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49234a0...3bf28ef. Read the comment docs.

@ernado ernado merged commit 9888c08 into gotd:main May 7, 2021
12 checks passed
@shadowspore shadowspore deleted the fix/race-cond-full-codec branch June 9, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants