Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): assert caller for SkipExternal #326

Merged
merged 1 commit into from May 7, 2021
Merged

test(e2e): assert caller for SkipExternal #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 18 additions & 1 deletion internal/testutil/external.go
View file
Open in desktop
Expand Up @@ -2,17 +2,34 @@ package testutil

import (
"os"
"runtime"
"strconv"
"strings"
"testing"
)

// SkipExternal skips current test if GOTD_TEST_EXTERNAL is not 1.
//
// Caller should be high-level test function with TestExternalE2E prefix,
// like TestExternalE2EConnect.
//
// Run all tests with following command in module root:
// GOTD_TEST_EXTERNAL=1 go test -v -run ^TestExternalE2E ./...
func SkipExternal(tb testing.TB) {
const env = "GOTD_TEST_EXTERNAL"

tb.Helper()

// TODO(ar): We can check test function for TestExternalE2E* prefix here.
{
// Checking caller prefix.
const expectedPrefix = "TestExternalE2E"
pc, _, _, _ := runtime.Caller(1)
details := runtime.FuncForPC(pc)
name := details.Name()[strings.LastIndex(details.Name(), ".")+1:]
if !strings.HasPrefix(name, expectedPrefix) {
tb.Fatalf("Test function %s should have prefix %s.", name, expectedPrefix)
}
}

if ok, _ := strconv.ParseBool(os.Getenv(env)); !ok {
tb.Skipf("Skipped. Set %s=1 to enable external e2e test.", env)
Expand Down