Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telegram): 64-bit alignment of client struct #881

Merged
merged 1 commit into from Sep 17, 2022

Conversation

iyear
Copy link
Contributor

@iyear iyear commented Sep 17, 2022

Put migration in the header of the structure to ensure 64-bit alignment, otherwise it will cause the atomic operation of connsCounter to panic.

https://pkg.go.dev/sync/atomic#pkg-note-BUG

fix #878

@ernado ernado self-assigned this Sep 17, 2022
@ernado ernado merged commit 50ddefd into gotd:main Sep 17, 2022
16 checks passed
@iyear iyear deleted the fix-client-64bit-alignment branch September 17, 2022 12:22
@iyear iyear restored the fix-client-64bit-alignment branch September 21, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: panic: unaligned 64-bit atomic operation on 32-bit machine
2 participants