Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session): fix encoding, use tg.Config subset #886

Merged
merged 2 commits into from Sep 25, 2022
Merged

Conversation

ernado
Copy link
Member

@ernado ernado commented Sep 25, 2022

The tg.Config cannot be marshalled from json now,
fixing it and reducing it to subset.

This should be backward compatible.

Fix #885

ernado added 2 commits Sep 25, 2022
The tg.Config cannot be marshalled from json now,
fixing it and reducing it to subset.

This should be backward compatible.
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #886 (f2ce9e7) into main (f8b8bd8) will increase coverage by 0.03%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   69.73%   69.76%   +0.03%     
==========================================
  Files         444      444              
  Lines       21172    21174       +2     
==========================================
+ Hits        14765    14773       +8     
+ Misses       5470     5468       -2     
+ Partials      937      933       -4     
Impacted Files Coverage Δ
session/session.go 48.27% <50.00%> (+1.60%) ⬆️
session/tdesktop.go 70.76% <100.00%> (-8.36%) ⬇️
telegram/session.go 76.92% <100.00%> (ø)
internal/mtproto/salt.go 73.33% <0.00%> (-13.34%) ⬇️
internal/mtproto/write.go 83.78% <0.00%> (-8.11%) ⬇️
internal/rpc/engine.go 77.40% <0.00%> (+2.82%) ⬆️
tgtest/handle.go 40.19% <0.00%> (+2.94%) ⬆️
internal/mtproto/conn.go 95.55% <0.00%> (+3.33%) ⬆️
tgtest/server.go 83.05% <0.00%> (+3.38%) ⬆️
internal/mtproto/read.go 61.22% <0.00%> (+4.76%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ernado ernado merged commit e53a803 into main Sep 25, 2022
18 checks passed
@ernado ernado deleted the fix-session-encoding branch Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tg.Config: load: unmarshal: json: cannot unmarshal object into Go struct field
1 participant