New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some CmdOps to make `RunCmd` more useful #122

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@vdemeester
Member

vdemeester commented Sep 18, 2018

Adding WithTimeout, WithEnv, Dir and WithStdin as I think those are the most used/required.

This way we can start using icmd.RunCmd with those operators instead of always creating icmd.Cmd manually 馃懠

Signed-off-by: Vincent Demeester vincent@sbr.pm

@vdemeester vdemeester requested a review from dnephin Sep 18, 2018

@dnephin

LGTM with the small type change for godoc

Show outdated Hide outdated icmd/ops.go Outdated
Add some CmdOps to make `RunCmd` more useful
adding WithTimeout, WithEnv, Dir and WithStdin as I think those are
the most used/required.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 19, 2018

Codecov Report

Merging #122 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   82.45%   82.02%   -0.43%     
==========================================
  Files          27       28       +1     
  Lines        1926     1947      +21     
==========================================
+ Hits         1588     1597       +9     
- Misses        232      244      +12     
  Partials      106      106
Impacted Files Coverage 螖
icmd/ops.go 0% <0%> (酶)
x/subtest/context.go 91.3% <0%> (+5.59%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 92091b3...6476d9a. Read the comment docs.

codecov bot commented Sep 19, 2018

Codecov Report

Merging #122 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   82.45%   82.02%   -0.43%     
==========================================
  Files          27       28       +1     
  Lines        1926     1947      +21     
==========================================
+ Hits         1588     1597       +9     
- Misses        232      244      +12     
  Partials      106      106
Impacted Files Coverage 螖
icmd/ops.go 0% <0%> (酶)
x/subtest/context.go 91.3% <0%> (+5.59%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 92091b3...6476d9a. Read the comment docs.

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester Sep 19, 2018

Member

@dnephin Updated 馃槈

Member

vdemeester commented Sep 19, 2018

@dnephin Updated 馃槈

@dnephin dnephin merged commit 0f2269b into gotestyourself:master Sep 20, 2018

9 of 10 checks passed

codecov/patch 0% of diff hit (target 82.45%)
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test-golang-1.10 Your tests passed on CircleCI!
Details
ci/circleci: test-golang-1.11 Your tests passed on CircleCI!
Details
ci/circleci: test-golang-1.8 Your tests passed on CircleCI!
Details
ci/circleci: test-golang-1.9 Your tests passed on CircleCI!
Details
codecov/project 82.02% (-0.43%) compared to 92091b3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@vdemeester vdemeester deleted the vdemeester:more-icmd-cmdops branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment