Navigation Menu

Skip to content

Commit

Permalink
mergetool: fix running mergetool in sub-directories
Browse files Browse the repository at this point in the history
The previous fix to mergetool to use checkout-index instead of cat-file
broke running mergetool anywhere except the root of the repository.

This fixes it by using the correct relative paths for temporary files
and index paths.

Signed-off-by: Charles Bailey <charles@hashpling.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
hashpling authored and gitster committed Jan 31, 2009
1 parent b9b5078 commit ff4a185
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions git-mergetool.sh
Expand Up @@ -13,7 +13,6 @@ SUBDIRECTORY_OK=Yes
OPTIONS_SPEC=
. git-sh-setup
require_work_tree
prefix=$(git rev-parse --show-prefix)

# Returns true if the mode reflects a symlink
is_symlink () {
Expand Down Expand Up @@ -131,7 +130,7 @@ checkout_staged_file () {
tmpfile=$(expr "$(git checkout-index --temp --stage="$1" "$2")" : '\([^ ]*\) ')

if test $? -eq 0 -a -n "$tmpfile" ; then
mv -- "$tmpfile" "$3"
mv -- "$(git rev-parse --show-cdup)$tmpfile" "$3"
fi
}

Expand Down Expand Up @@ -161,9 +160,9 @@ merge_file () {
local_mode=`git ls-files -u -- "$MERGED" | awk '{if ($3==2) print $1;}'`
remote_mode=`git ls-files -u -- "$MERGED" | awk '{if ($3==3) print $1;}'`

base_present && checkout_staged_file 1 "$prefix$MERGED" "$BASE"
local_present && checkout_staged_file 2 "$prefix$MERGED" "$LOCAL"
remote_present && checkout_staged_file 3 "$prefix$MERGED" "$REMOTE"
base_present && checkout_staged_file 1 "$MERGED" "$BASE"
local_present && checkout_staged_file 2 "$MERGED" "$LOCAL"
remote_present && checkout_staged_file 3 "$MERGED" "$REMOTE"

if test -z "$local_mode" -o -z "$remote_mode"; then
echo "Deleted merge conflict for '$MERGED':"
Expand Down
2 changes: 1 addition & 1 deletion t/t7610-mergetool.sh
Expand Up @@ -66,7 +66,7 @@ test_expect_success 'mergetool crlf' '
git reset --hard
'

test_expect_failure 'mergetool in subdir' '
test_expect_success 'mergetool in subdir' '
git checkout -b test3 branch1
cd subdir && (
test_must_fail git merge master >/dev/null 2>&1 &&
Expand Down

0 comments on commit ff4a185

Please sign in to comment.