Skip to content
This repository

May 15, 2011

  1. Ævar Arnfjörð Bjarmason

    git-sh-i18n.sh: add no-op gettext() and eval_gettext() wrappers

    Add a no-op wrapper library for Git's shell scripts. To split up the
    gettext series I'm first submitting patches to gettextize the source
    tree before I add any of the Makefile and Shell library changes needed
    to actually use them.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored gitster committed
  2. Ævar Arnfjörð Bjarmason

    git-sh-i18n--envsubst: our own envsubst(1) for eval_gettext()

    Add a git-sh-i18n--envsubst program which is a stripped-down version
    of the GNU envsubst(1) program that comes with GNU gettext for use in
    the eval_gettext() fallback.
    
    We need a C helper program because implementing eval_gettext() purely
    in shell turned out to be unworkable. Digging through the Git mailing
    list archives will reveal two shell implementations of eval_gettext
    that are almost good enough, but fail on an edge case which is tested
    for in the tests which are part of this patch.
    
    These are the modifications I made to envsubst.c as I turned it into
    sh-i18n--envsubst.c:
    
     * Added our git-compat-util.h header for xrealloc() and friends.
    
     * Removed inclusion of gettext-specific headers.
    
     * Removed most of main() and replaced it with my own. The modified
       version only does option parsing for --variables. That's all it
       needs.
    
     * Modified error() invocations to use our error() instead of
       error(3).
    
     * Replaced the gettext XNMALLOC(n, size) macro with just
       xmalloc(n). Since XNMALLOC() only allocated char's.
    
     * Removed the string_list_destroy function. It's redundant (also in
       the upstream code).
    
     * Replaced the use of stdbool.h (a C99 header) by doing the following
       replacements on the code:
    
        * s/bool/unsigned short int/g
        * s/true/1/g
        * s/false/0/g
    
    Reported-by: Johannes Sixt <j.sixt@viscovery.net>
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored gitster committed

Feb 13, 2011

  1. Ævar Arnfjörð Bjarmason

    gitignore: add test-mktemp to ignore list

    Change the .gitignore to ignore test-mktemp which is built from
    test-mktemp.c. Arnout Engelen added this in 6cf6bb3 (Improve error
    messages when temporary file creation fails, 2010-12-18) but forgot
    to add a corresponding entry to .gitignore.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored gitster committed

Aug 18, 2010

  1. Ævar Arnfjörð Bjarmason

    Makefile: Add cover_db_html target

    Add a target to generate a detailed HTML report for the entire Git
    codebase using Devel::Cover's cover(1) tool. Output it in
    cover_db_html instead of the default cover_db, so that it isn't mixed
    up with our raw report files.
    
    The target depends on the coverage-report-cover-db target, it may be
    run redundantly if it was previously run. But the HTML output won't be
    affected by running gcov2perl twice, so I didn't try to avoid that
    small redundancy.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored gitster committed
  2. Ævar Arnfjörð Bjarmason

    Makefile: Add cover_db target

    Add a target to convert the *.gcov files to a Devel::Cover
    database. That database can subsequently be formatted by the cover(1)
    tool which is included with Devel::Cover.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored gitster committed
  3. Ævar Arnfjörð Bjarmason

    gitignore: Ignore files generated by "make coverage"

    The "make coverage" support added by Thomas Rast in 901c369 didn't
    contain a corresponding patch to patch .gitignore.
    
    Change gitignore to ignore the *.gcda, *.gcno and *.gcov files
    generated by GCC and our coverage invocations.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored gitster committed
Something went wrong with that request. Please try again.