Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the 'http' crate #26

Closed
bradleybeddoes opened this Issue Aug 16, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@bradleybeddoes
Copy link
Contributor

bradleybeddoes commented Aug 16, 2017

This was recently announced at https://users.rust-lang.org/t/announcing-the-http-crate/12123.

We'll need support in Hyper before we can migrate to this but once that has occurred we should be able to get there quite quickly given the way we've already made use of similar types from Hyper directly instead of reinventing this particular wheel.

https://github.com/carllerche/http
https://carllerche.github.io/http/http/index.html

@bradleybeddoes bradleybeddoes self-assigned this Aug 18, 2017

@bradleybeddoes bradleybeddoes removed the blocked label Jan 10, 2018

@bradleybeddoes bradleybeddoes added this to the 0.3 milestone Jan 23, 2018

@n-pochet

This comment has been minimized.

Copy link
Contributor

n-pochet commented Feb 9, 2018

Hi,
I looked a little bit about that yesterday and it seems that Hyper is providing compatibility with the http crate by using the compat feature in Hyper.
What is still unclear for me is the amount of rework that such change would imply.
How far would we like to go with the integration?

@bradleybeddoes

This comment has been minimized.

Copy link
Contributor Author

bradleybeddoes commented Feb 9, 2018

I'm actually a little ways down the rabbit hole on this one, there is a reasonable amount of change going on, more than I anticipated but not unachievable.

I am considering holding that effort until Hyper 0.12 comes along which remove the compat feature flag and integrate with the http crate directly (or so I understood it to be anyways from a brief reddit discussion I had with @seanmonstar).

Either way this won't ship with Gotham 0.2, which is firming up for late February now.

@whitfin

This comment has been minimized.

Copy link
Contributor

whitfin commented Sep 19, 2018

@nyarly would you say we can close this given the Hyper 0.12 migration?

@whitfin whitfin closed this Sep 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.