New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express w/ Bookshelf.js #212

Closed
Cameron-C-Chapman opened this Issue Apr 28, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Cameron-C-Chapman
Member

Cameron-C-Chapman commented Apr 28, 2018

https://github.com/tanem/express-bookshelf-realworld-example-app

  • Fork the starter repo & post the link in this issue
  • Create logo for repo & update issue status
  • Implement all of Conduit's functionality per the spec & API
  • Move repo to main org & Peer review final codebase
  • Tag v1 release and officially list it on the README
@tanem

This comment has been minimized.

tanem commented May 21, 2018

Hey @Cameron-C-Chapman, I just merged down a bunch of stuff re docker-compose, so I think the repo is ready for at least an initial glance? 👀

I've noted it in the testing part of the README, but the project is passing it's internal test suite as well as the realworld-server-tester.

There's definitely more that can be done to improve things (e.g. docs, some parts of the implementation where I have less exp.) so I'd be super grateful for any feedback at all 🙏

Thanks!

@Cameron-C-Chapman

This comment has been minimized.

Member

Cameron-C-Chapman commented Jul 14, 2018

I think this looks awesome @tanem! Great work! I'll go ahead and get this added to the main repo.

Awesome job! 🎉

@tanem

This comment has been minimized.

tanem commented Jul 15, 2018

That's great 😃 Thanks for taking the time to do this @Cameron-C-Chapman!

PS I'll be going back over the README/docs at some point, but if there's anything you need me to add there in order to adhere to any README styleguide you have (images, layout etc), please let me know 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment