New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter #312

Open
CasterKKK opened this Issue Dec 14, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@CasterKKK
Copy link

CasterKKK commented Dec 14, 2018

I know #250 is already talk about flutter, but he doesn't give us a project to work with, so I wrote my version of Flutter App: https://github.com/CasterKKK/flutter_realworld_app, and I have finished all the features in the spec (I think)

Any PR or advice is great!

@meritonferati

This comment has been minimized.

Copy link

meritonferati commented Dec 21, 2018

I know #250 is already talk about flutter, but he doesn't give us a project to work with, so I wrote my version of Flutter App: https://github.com/CasterKKK/flutter_realworld_app, and I have finished all the features in the spec (I think)

Any PR or advice is great!

Thank you for your work. It looks great..

@anishkny anishkny changed the title Flutter Framework Finished Flutter Jan 8, 2019

@lastlink

This comment has been minimized.

Copy link

lastlink commented Jan 8, 2019

I've done some pull requests to the repo, what is remaining for this to be closed? Great work btw @CasterKKK

@anishkny

This comment has been minimized.

Copy link
Member

anishkny commented Jan 8, 2019

@CasterKKK @lastlink it would be helpful to build this project on some CI to ensure it build correctly.

@CasterKKK

This comment has been minimized.

Copy link

CasterKKK commented Jan 8, 2019

@anishkny well, in fact I don't know how to use CI very well, so it well take a very long time to add CI to this project, sorry

@CasterKKK

This comment has been minimized.

Copy link

CasterKKK commented Jan 8, 2019

@lastlink I merged your PRs so it your PRs and branchs closed. Did I do anything wrong? The wierd thing is why are not you on the contribution list...

@lastlink

This comment has been minimized.

Copy link

lastlink commented Jan 8, 2019

@CasterKKK you have to add users manually to have them on the contributor list. The way open-sourced projects work is that people can fork and do a pull request to the repository forked from. If I or someone else is a contributor then I can do direct pushes to the main repository. I do show up under insights > contributors though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment