Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter #312

Open
UkonnRa opened this issue Dec 14, 2018 · 9 comments
Open

Flutter #312

UkonnRa opened this issue Dec 14, 2018 · 9 comments
Labels

Comments

@UkonnRa
Copy link

@UkonnRa UkonnRa commented Dec 14, 2018

I know #250 is already talk about flutter, but he doesn't give us a project to work with, so I wrote my version of Flutter App: https://github.com/CasterKKK/flutter_realworld_app, and I have finished all the features in the spec (I think)

Any PR or advice is great!

@meritonferati
Copy link

@meritonferati meritonferati commented Dec 21, 2018

I know #250 is already talk about flutter, but he doesn't give us a project to work with, so I wrote my version of Flutter App: https://github.com/CasterKKK/flutter_realworld_app, and I have finished all the features in the spec (I think)

Any PR or advice is great!

Thank you for your work. It looks great..

@anishkny anishkny changed the title Flutter Framework Finished Flutter Jan 8, 2019
@lastlink
Copy link

@lastlink lastlink commented Jan 8, 2019

I've done some pull requests to the repo, what is remaining for this to be closed? Great work btw @CasterKKK

@anishkny
Copy link
Member

@anishkny anishkny commented Jan 8, 2019

@CasterKKK @lastlink it would be helpful to build this project on some CI to ensure it build correctly.

@UkonnRa
Copy link
Author

@UkonnRa UkonnRa commented Jan 8, 2019

@anishkny well, in fact I don't know how to use CI very well, so it well take a very long time to add CI to this project, sorry

@UkonnRa
Copy link
Author

@UkonnRa UkonnRa commented Jan 8, 2019

@lastlink I merged your PRs so it your PRs and branchs closed. Did I do anything wrong? The wierd thing is why are not you on the contribution list...

@lastlink
Copy link

@lastlink lastlink commented Jan 8, 2019

@CasterKKK you have to add users manually to have them on the contributor list. The way open-sourced projects work is that people can fork and do a pull request to the repository forked from. If I or someone else is a contributor then I can do direct pushes to the main repository. I do show up under insights > contributors though.

@JankoLancer
Copy link

@JankoLancer JankoLancer commented May 20, 2019

@CasterKKK I would like to contribute to this project.
Can you tell me what job is left to be done?

@UkonnRa
Copy link
Author

@UkonnRa UkonnRa commented May 20, 2019

@JankoLancer Thanks for helping, you can find anything you are interested in. For example, the comment part is missing, and testing is prefered

@satvikpendem
Copy link

@satvikpendem satvikpendem commented Aug 29, 2020

Can this be put on the main page instead of as a work in progress as it seems to be finished? Or am I mistaken and there's still work to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants