Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃梽馃敡 Symfony #66

Open
dakenf opened this issue Apr 27, 2017 · 23 comments
Open

馃梽馃敡 Symfony #66

dakenf opened this issue Apr 27, 2017 · 23 comments

Comments

@dakenf
Copy link

@dakenf dakenf commented Apr 27, 2017

Current Status

Todo:

  • 馃弫 Fork the starter repo & post the link in this issue
  • 馃帹 Create logo for repo & update issue status (@EricSimons)
  • 馃敤 Implement all of Conduit's functionality per the spec & API
  • 馃憖 Move repo to main org & Peer review final codebase by admins/community (RFC)
  • 馃帀 Tag v1 release and officially list it on the README!

Hi! I'd like to implement the backend with Symfony 3 framework. I've created a repo here https://github.com/dakenf/realword-symfony

@EricSimons
Copy link
Member

@EricSimons EricSimons commented Apr 28, 2017

Awesome! Just updated issue status w/ a gitter room where we can do collaborator coordination, etc :) Also, here's a logo that you can use for your repo's readme:

symphony

@sandeesh
Copy link
Member

@sandeesh sandeesh commented May 12, 2017

@dakenf Any progress on this? I might help out if there's no progress happening.

@linxlad
Copy link

@linxlad linxlad commented May 27, 2017

Any word on this repo? @SandeeshS I'd be happy to join you :)

@sandeesh
Copy link
Member

@sandeesh sandeesh commented May 27, 2017

@linxlad i guess this never got started. I'm planning to pick this up next weekend when i get time. If you'd like to then go ahead and create a new repo and start on it. I'll jump in when i get the time and continue in your repo.

I'll update the main comment with the new repo if you create one.

@linxlad
Copy link

@linxlad linxlad commented May 27, 2017

@SandeeshS Sure, I have nearly finished the Phalcon repo, will create a new repo with config, migrations and models :)

@matigda
Copy link

@matigda matigda commented Jul 12, 2017

So how does it look right now? Has anyone started it or nope? If I want to contribute then is this the repo I should use - https://github.com/dakenf/realword-symfony ? @linxlad ?

@EricSimons
Copy link
Member

@EricSimons EricSimons commented Aug 28, 2017

@matigda sorry about my delay here! Would you want to take over this project? I think the other folks ended up not having enough time :(

@wesol05
Copy link

@wesol05 wesol05 commented Sep 2, 2017

I can help @matigda with it

@matigda
Copy link

@matigda matigda commented Sep 3, 2017

We will start with vesol on that in here: https://github.com/matigda/gothinkster
any help appreciated :)

@matigda
Copy link

@matigda matigda commented Sep 27, 2017

hey @EricSimons , is it possible to create symfony repo in gothinkster organization? Or should it stay as mine? I'm still in develop process and I will fix "README" soon ;)

@EricSimons
Copy link
Member

@EricSimons EricSimons commented Sep 27, 2017

@matigda feel free to keep it in your own account until it's feature complete! Once it's ready I'll spin up a new repo for it and add you to it :)

@guillaumemaka
Copy link

@guillaumemaka guillaumemaka commented Nov 22, 2017

@matigda So how does it look right now?

@matigda
Copy link

@matigda matigda commented Dec 7, 2017

@guillaumemaka I gave link to repository ;) step by step but moving forward. You're welcome to create PRs :)
I've started moving it to Sf4 and I will soon commit it.

@arrrni
Copy link

@arrrni arrrni commented Dec 12, 2017

@matigda what is working by far?

@matigda
Copy link

@matigda matigda commented Dec 13, 2017

@arrrni can you guys please take a look at the code before asking? There are functional tests in behat for what is working and there is also configured docker so you can easily run it.

@EricSimons
Copy link
Member

@EricSimons EricSimons commented Dec 19, 2017

@matigda I've gone ahead and made your repo the one linked in this issue 鈥 can't wait to see the final version!

@florentdestremau
Copy link

@florentdestremau florentdestremau commented Jul 1, 2019

Hello ! Is this issue still relevant ? I could help out for the Symfony backend in order to promote the framework :)
It would be better to do it in Symfony 4. and possibly do it with API Platform (as it is a framework for symfony, frameworkception !), maybe on a separate issue

@matigda
Copy link

@matigda matigda commented Jul 1, 2019

There is already some work done. Have you checked out the repo? IMO it would be best to NOT use any external libraries. It's very simple CRUD. Way better for other people to learn basics of framework and architecture if it's based on simplicity, not external dependencies.

@florentdestremau
Copy link

@florentdestremau florentdestremau commented Jul 1, 2019

I've seen the repo and I gotta say, I really don't like the structure of the src file because I don't think it follows the Symfony best practices' way of naming and ordering things.
Although I like the testing part a lot, I think that it doesn't reflect the "Symfony way":

src
 Controller
 Entity
 Repository

What I expect from this repository is to follow the docs with as much precision as possible so that any beginner can check out the docs and see clearly where are files located and what are they doing, and I think the Application / Domain / Infrastructure is not documented anywhere, It probably is a stable and durable file structure but as said in the specs,

The quality & architecture of Conduit implementations should reflect something similar to an early stage startup's MVP: functionally complete & stable, but not unnecessarily over-engineered.

And I think this is over-engineered. What do you think ? I could help out moving the differents files to match the "standard" symfony genrated doc structure

@matigda
Copy link

@matigda matigda commented Jul 1, 2019

Not sure if it is cause I got used to "screaming architecture". It may be, but it's just something natutal to me. If you are willing to change current code - go on with that. But then please make sure you make it from the beginning to the end. There were already few approaches from different people and every one canceled in the middle.

@florentdestremau
Copy link

@florentdestremau florentdestremau commented Jul 1, 2019

I won't start anything if I'm not confident that I can do it completely. I'll think about this :)

@seyfer
Copy link

@seyfer seyfer commented Oct 13, 2019

@florentdestremau Application / Domain / Infrastructure is a usual structure for DDD and Hexagonal Architecture apps, which is widely used with Symfony. Personally I think this is a better Real World example than just following the structure proposed by the framework.

@florentdestremau
Copy link

@florentdestremau florentdestremau commented Oct 14, 2019

@seyfer if you want to show a "by the book" symfony web app, Hexagonal is not included. Because this is framework - agnostic, I don't think it should be reflected, or at least there should be 2 versions.

Anyway, I am guilty of not having time to offer for this project, I'm just hoping someone will find the time to finish this 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants
You can鈥檛 perform that action at this time.