Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃梽馃敡 Phalcon #88

Open
linxlad opened this issue May 3, 2017 · 16 comments
Open

馃梽馃敡 Phalcon #88

linxlad opened this issue May 3, 2017 · 16 comments
Labels

Comments

@linxlad
Copy link

@linxlad linxlad commented May 3, 2017

Current Status

  • 馃弫 Fork the starter repo & post the link in this issue
  • 馃帹 Create logo for repo & update issue status (@EricSimons)
  • 馃敤 Implement all of Conduit's functionality per the spec & API
  • 馃憖 Peer review of final codebase by RealWorld admins & community (RFC)
  • 馃帀 Tag v1 release, move repo to main org, and officially list it on the README!

Hey, I would like to implement a backend example with Phalcon.

@linxlad
Copy link
Author

@linxlad linxlad commented May 3, 2017

@EricSimons Is it possible to work your magic on the logo? :)

@EricSimons
Copy link
Member

@EricSimons EricSimons commented May 3, 2017

@linxlad yessir! :)

phalcon

@linxlad
Copy link
Author

@linxlad linxlad commented May 3, 2017

Thank you kind sir :)

@EricSimons EricSimons changed the title Phalcon 馃梽馃敡 Phalcon May 3, 2017
@linxlad
Copy link
Author

@linxlad linxlad commented May 15, 2017

API Tasks:

Articles

  • GET - Feed
  • GET - All articles
  • GET - Articles by author
  • GET - Articles favorited by username
  • GET - Articles by tag
  • POST - Create article
  • GET - Single article by slug
  • DEL - Delete article
  • PUT - Update article
  • POST - Favorite article
  • DEL - Unfavorite article

Auth

  • POST - Login
  • POST - Login and remember token
  • POST - Register
  • GET - Get current user
  • PUT - Update user

Comments

  • GET - All comments for article
  • POST - Create comment for article
  • DEL - Delete comment

Profile

  • GET - Profile
  • POST - Follow profile
  • DEL - Unfollow profile

Tags

  • GET - Get all tags
@linxlad
Copy link
Author

@linxlad linxlad commented May 21, 2017

@EricSimons @SandeeshS Not a biggie but Phalcon is missing from the Work In Progress README section :)

@sandeesh
Copy link
Member

@sandeesh sandeesh commented May 22, 2017

@linxlad ah sorry about that. Guess Eric missed it on the last update. I'll create a PR to add this 馃憤

@sandeesh
Copy link
Member

@sandeesh sandeesh commented May 22, 2017

@linxlad added with #114 @EricSimons will merge it when he's online. I've also sorted the list alphabetically so that people don't take offense with one being ahead of another :D

@linxlad
Copy link
Author

@linxlad linxlad commented May 22, 2017

Thanks :)

@EricSimons
Copy link
Member

@EricSimons EricSimons commented May 22, 2017

Thanks for the PR @SandeeshS! Sorry about that @linxlad 鈥 can be kinda hard to keep track of all of the implementations currently in the pipeline 馃槗

@linxlad
Copy link
Author

@linxlad linxlad commented May 23, 2017

@EricSimons It's no problem at all, just thought I'd mention it, I appreciate the size of the workload you have to deal with, keep up the good work :)

@linxlad
Copy link
Author

@linxlad linxlad commented Jun 4, 2017

@EricSimons @SandeeshS I have completed functionality. I am currently introducing CI and tests but would be nice to get the peer reviews started so I can make improvements

NB: I will probably making regular improvements to reflect the latest releases of Phalcon. Also there are some methods I would like to revisit at a later stage.

@sandeesh
Copy link
Member

@sandeesh sandeesh commented Jun 7, 2017

@linxlad awesome 馃憤 I missed the last notification and didn't read the message. You can add the tests slowly taking your time, no hurry. I'd love to test this on my end once but i don't see any instructions to get this running without docker. Is there any simple way i can get this up and running and test the api locally? Also we can move this repo and get this listed once all the tests come out green :)

@linxlad
Copy link
Author

@linxlad linxlad commented Jun 7, 2017

@SandeeshS

I will update the readme this evening with everything.

Phalcon is a compiled C extension for PHP. So I provided the docker/nanobox as they have the extension pre-loaded. However if you want to run this in another environment (WAMP/LAMP for example) you would need to download the latest extension and add it yourself :)

Extensions for Linux
Extensions for Windows

@linxlad
Copy link
Author

@linxlad linxlad commented Jul 6, 2017

How can I continue having this peer reviewed? :)

@EricSimons
Copy link
Member

@EricSimons EricSimons commented Jul 6, 2017

@linxlad getting it running locally now :) Have you fully tested it against one of the frontends to make sure all works properly? If so, I'll set up the official repo for this!

@geoidesic
Copy link

@geoidesic geoidesic commented Jan 6, 2018

@linxlad well, have you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can鈥檛 perform that action at this time.