Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl package to enable Docker healthcheck #308

Closed
sadmin91 opened this issue May 2, 2020 · 4 comments
Closed

Add curl package to enable Docker healthcheck #308

sadmin91 opened this issue May 2, 2020 · 4 comments
Labels
a:feature New feature or request
Milestone

Comments

@sadmin91
Copy link

sadmin91 commented May 2, 2020

Is your feature request related to a problem? Please describe.
I am using your image for my personal use.
Actually, I build a custom image (using your image as source) in order to add curl package to create a healtcheck for my swarm service.
I think the addition of this package could help others users.

Describe the solution you'd like
Add curl package on Docker image

Describe alternatives you've considered
Build a custom Docker image to add this package

@sadmin91 sadmin91 added the a:feature New feature or request label May 2, 2020
@jmattheis
Copy link
Member

I think we can also include the healthcheck to our docker images.

What do you think of this?

FROM frolvlad/alpine-glibc:glibc-2.31
WORKDIR /app
RUN apk add --no-cache ca-certificates tzdata curl
ADD gotify-app /app/
HEALTHCHECK --interval=30s --timeout=5s --start-period=5s CMD curl --fail http://localhost:80/health || exit 1
EXPOSE 80
ENTRYPOINT ["./gotify-app"]

@sadmin91
Copy link
Author

sadmin91 commented May 3, 2020

@jmattheis Yes, i'm doing this today.
But why not include curl package on the official Gotify image?

@jmattheis
Copy link
Member

Ahh, I'm planning on including this in the official image :D.

@jmattheis jmattheis added this to the version+1 milestone May 4, 2020
@jmattheis
Copy link
Member

Fixed with #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request
Development

No branches or pull requests

2 participants