Add a pointer to #350 from the ARM Dockerfiles #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Jan 28, 2022
| @@ -1,5 +1,8 @@ | |||
| # Note: Due to https://github.com/gotify/server/issues/350 this Dockerfile | |||
There was a problem hiding this comment.
Well, it can be added, but then the ci build must be adjusted accordingly. I don't think such a comment is needed, because the issue already exists.
|
Well I, at least, was confused. Reading the source it seems like an oversight (the "main" Dockerfile is more feature-rich than the ARM variants, with no comment explaining the difference). Adding a pointer to the tracking issue would help readers understand a) the disparity is intentional and b) where to follow along for updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.