Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers to configuration #88

Merged

Conversation

2 participants
@madding
Copy link
Contributor

commented Nov 28, 2018

No description provided.

@madding

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

@jmattheis I fixed this issue #23, please make review.

@codecov

This comment has been minimized.

Copy link

commented Nov 28, 2018

Codecov Report

Merging #88 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #88   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         785    787    +2     
=====================================
+ Hits          785    787    +2
Impacted Files Coverage Δ
config/config.go 100% <ø> (ø) ⬆️
router/router.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77c1b1...1d62816. Read the comment docs.

@jmattheis
Copy link
Member

left a comment

Hey @madding,
thanks for your third contribution!

I've added some comments for improvement.

Show resolved Hide resolved config/config.go Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved router/router_test.go Outdated

@madding madding force-pushed the madding:23/add-response-headers-to-configuration branch from 2efe2bc to 32579e6 Nov 30, 2018

Show resolved Hide resolved config/config.go Outdated
Show resolved Hide resolved config/config_test.go
Show resolved Hide resolved router/router_test.go Outdated
Show resolved Hide resolved router/router_test.go Outdated
Show resolved Hide resolved router/router_test.go Outdated
@jmattheis

This comment has been minimized.

Copy link
Member

commented Dec 3, 2018

Could you squash all your commits?

@madding madding force-pushed the madding:23/add-response-headers-to-configuration branch from 89f9be2 to 1d62816 Dec 3, 2018

@jmattheis
Copy link
Member

left a comment

Thanks!

@jmattheis jmattheis merged commit b42beb0 into gotify:master Dec 4, 2018

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to c77c1b1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.