Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(type): add support for metric asset #73

Merged
merged 1 commit into from
Apr 30, 2024
Merged

feat(type): add support for metric asset #73

merged 1 commit into from
Apr 30, 2024

Conversation

haveiss
Copy link
Collaborator

@haveiss haveiss commented Apr 25, 2024

No description provided.

@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited

Pull Request Test Coverage Report for Build 8829392185

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 85.14%
Totals Coverage Status
Change from base Build 7420818435: 0.002%
Covered Lines: 6337
Relevant Lines: 7443
💛 - Coveralls

rahmatrhd
rahmatrhd reviewed Apr 25, 2024
View reviewed changes
core/asset/type_test.go Outdated Show resolved Hide resolved
@haveiss haveiss requested a review from rahmatrhd April 25, 2024 08:27
@haveiss haveiss merged commit ccafc94 into main Apr 30, 2024
3 checks passed
@haveiss haveiss deleted the feat/introduce-metric-type branch April 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

@StewartJingga StewartJingga StewartJingga approved these changes

@anjali9791 anjali9791 anjali9791 approved these changes

@batrov batrov batrov approved these changes

@utsav14nov utsav14nov Awaiting requested review from utsav14nov

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@haveiss @coveralls @mabdh @rahmatrhd @StewartJingga @anjali9791 @batrov