-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku: disable qtsingleapplication #197
Conversation
|
Why does Haiku need QtSingleApplication disabled? I would prefer to fix it if possible rather than just disable it. |
|
Does haiku support QSharedMemory? I think I may have found a way to replace the lockfile with that. FocusWriter was written with the assumption that there is only one instance running, and it would require a massive rewrite to ensure that multiple instances wouldn't clobber things like the emergency cache or the daily progress. Because of that, I am not going to merge this pull request. |
|
Hi, @gottcode
I'm not sure, but i believe it doesn't, does your solution involves QSharedMemory? |
|
@khallebal Yes, unfortunately. What about QLockFile? Does haiku support that? If you need to test to find out, I could push a branch to GitHub for you to try. |
@gottcode , Please do so, as i don't know if haiku supports QLockFile either. |
|
@khallebal I have made a qlockfile branch for you to test. Thanks! |
|
I set up a haiku nightly build in a virtual machine. The QSharedMemory version does indeed have issues, but the QLockFile branch works. As does the current version! If I kill FocusWriter, it leaves the lockfile, but that doesn't prevent it from starting up again for me. Are you sure it needs to be fixed? |
I did the exact same thing and got the same result, so yes this fix is needed for haiku, thanks alot for fixing this. Now that this is done, i have a patch i'd like to submit(if it's okay with you), which is just a few additions to the "make install" routine in the .pro file (haiku has a different structure than most unix's) and a resource file which includes the icon as resources. You seem to know Qt quite well, so i'm gonna ask you something. `rc focuswriter.rdef`Which produces the binary "focuwriter.rsrc" `xres -o /path/to/focuswriter focuwriter.rsrc`to inject the resources `mimeset -f /path/to/focuswriter`to set the mime type & save the resources. `using null output device, none available`
`QCoreApplication::postEvent: Unexpected null receiver` |
I'm sorry, I'm confused. Are you saying the qlockfile branch works? Or the master branch? The part you quoted was from me testing the master branch and finding no changes were needed.
Sure, open a pull request and I will take a look.
I think you could probably use QMake's external commands to do that, but I'm not sure. FocusWriter can't be the first Qt program ported; how do the others solve this?
Sorry, nothing I can do. Haiku apparently doesn't support QSoundEffect, which is how FocusWriter plays sounds. |
I meant the qlockfile branch, but i tried again with the master branch just now and it also worked!, does it make a difference whether the app actually crashes or not? because when it crashed it didn't relaunch until i flushed the /tmp dir, that's why i submitted the patch in the first place. I'll submit my patch tomorrow. |
No description provided.