Grab available services per device and improve speaker detection #22

Merged
merged 1 commit into from Feb 4, 2014

Projects

None yet

3 participants

@scoop
Contributor
scoop commented Jan 1, 2014

This should solve issues with stereo pairs, SUB setups, and surround
speakers for the PLAYBAR by looking at the services provided by each device and only returning true from Speaker#speaker? if MusicServices are provided.

I couldn't get the tests to work, unfortunately.

@scoop scoop Grab available services per device and improve speaker detection
This should solve issues with stereo pairs, SUB setups, and surround
speakers for the PLAYBAR.
a85773b
@gotwalt
Owner
gotwalt commented Jan 1, 2014

Oh, smart. Is it that you couldn't run the tests, or that they failed? This has historically been a tricky project to test, and that effort has (frankly) languished a good bit.

@scoop
Contributor
scoop commented Jan 1, 2014

The error I got was:

/usr/local/opt/rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/minitest-wscolor-0.0.3/lib/minitest/wscolor.rb:47:in `<top (required)>': undefined method `output' for Minitest::Unit:Class (NoMethodError)

Nothing really specific to the test suite I guess. My MiniTest is a bit rusty at this point. Could also be a version conflict of some sort, since no Gemfile.lock was provided. Which versions of minitest and minitest-wscolor should I use?

I did test with Ruby 1.9.3, but ran into the same issue.

@gotwalt
Owner
gotwalt commented Jan 1, 2014

Confirmed locally. The entire test directory is worthless - only two tests, both that fail because they test properties that don't exist. That's after you remove minitest-wscolor, drop fakeweb (vcr removes fakeweb support soon), and fix the MiniTest namespacing.

@soffes
Collaborator
soffes commented Feb 4, 2014

Love it.

@soffes soffes merged commit 5969723 into gotwalt:master Feb 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment