Clean up HTML template #37

Merged
merged 2 commits into from Mar 31, 2013

Conversation

Projects
None yet
2 participants
Contributor

mathiasbynens commented Mar 18, 2013

See diff comments for more information.

</div>
-</body>
@mathiasbynens

mathiasbynens Mar 18, 2013

Contributor

All <script>s should be children of the <body> element, so I moved </body> down a few lines

@@ -1,18 +1,17 @@
<!doctype html>
-<html>
+<html lang="en">
@mathiasbynens

mathiasbynens Mar 18, 2013

Contributor

This has the same effect as <meta http-equiv="content-language" content="en">.

<head>
<title>Code coverage report for {{entity}}</title>
- <meta http-equiv="content-type" content="text/html; charset=UTF-8">
body, html {
margin:0; padding: 0;
}
body {
- font-family: "Helvetic Neue", Helvetica,Arial;
+ font-family: Helvetica Neue, Helvetica,Arial;
@mathiasbynens

mathiasbynens Mar 18, 2013

Contributor

"Helvetic Neue" is a typo (missing the a). Also, the quotes aren’t needed, so I removed them.

-<div class='header {{reportClass}}'>
- <h1>Code coverage report for <span class='entity'>{{entity}}</span></h1>
+<div class="header {{reportClass}}">
+ <h1>Code coverage report for <span class="entity">{{entity}}</span></h1>
@mathiasbynens

mathiasbynens Mar 18, 2013

Contributor

Used " consistently.

CSS: Add `tab-size`
This makes sure any tab characters in the source code don’t take up too much horizontal space in reports.
Contributor

mathiasbynens commented Mar 24, 2013

Added CSS tab-size as well.

Contributor

mathiasbynens commented Mar 29, 2013

Any feedback on this?

Owner

gotwarlost commented Mar 29, 2013

Sorry, haven't had time to look into it. Generally looks good. I will merge it in soon.

Thanks for the cleanup!

gotwarlost added a commit that referenced this pull request Mar 31, 2013

@gotwarlost gotwarlost merged commit 6e5be42 into gotwarlost:master Mar 31, 2013

1 check passed

default The Travis build passed
Details
Owner

gotwarlost commented Apr 1, 2013

Available in v0.1.34. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment