Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

YUI3 tests do not load correctly under YUI@3.9.2pr2 #8

Open
gotwarlost opened this Issue Jan 31, 2013 · 6 comments

Comments

Projects
None yet
2 participants
Owner

gotwarlost commented Jan 31, 2013

@davglass I might need you help on this.

Can you give me an example?

My YUIDoc tests all pass with pr2.

Owner

gotwarlost commented Jan 31, 2013

This one doesn't work:

https://github.com/gotwarlost/ytestrunner/tree/master/examples/yui3-custom-modules

To be fair, I haven't debugged this at all so feel free to wait for a first pass debug from me. It's probably some unexpected fake loader tricks that I'm using

This looks like its a path issue. We are now using the proper Node.js Module system under the hood to compile the modules. I think it's a relative path issue, I can change the config.json and put an absolute path in for the module and it works properly.

I don't have time to dig into ytestrunner to see how it resolves files, but it may need to resolve the file location properly since Loader was doing it wrong the old way.

Owner

gotwarlost commented Jan 31, 2013

I'll take a look. Thanks for the pointer.

Also, as an FYI, if you change this line:
https://github.com/gotwarlost/ytestrunner/blob/master/lib/yui3-test-runner.js#L41

To this:

var mod = libPath ? path.join(libPath, 'yui') : 'yui/debug';

You can see that Loader is not expanding the path for the file since it's relative it's looking in that dir for it and skipping, when it should be looking for it above there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment