Composerification #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning up composer.json
Correcting the package name
|
Hi @tobybellwood there are a number of issues with this PR, including conflicts. This is blocking #4 so I think it is best if we close this one and incorporate these changes in my next PR. Thoughts? |
jorgegc
suggested changes
Jul 2, 2018
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "name": "govcms/dvf", | |||
There was a problem hiding this comment.
Why are we namespacing it under govcms and not drupal?
| "issues": "https://www.drupal.org/project/issues/dvf" | ||
| }, | ||
| "license": "GPL-2.0+", | ||
| "version": "0.0.1", |
| "license": "GPL-2.0+", | ||
| "version": "0.0.1", | ||
| "minimum-stability": "alpha", | ||
| "prefer-stable": true, |
There was a problem hiding this comment.
This is not going to have any effect because prefer-stable is root-only.
| "version": "0.0.1", | ||
| "minimum-stability": "alpha", | ||
| "prefer-stable": true, | ||
| "require": { } |
There was a problem hiding this comment.
Empty require should be removed.
|
Happy to close and have a resubmit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.