Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocab link in menu busted #21

Open
galund opened this issue Mar 8, 2023 · 2 comments
Open

Vocab link in menu busted #21

galund opened this issue Mar 8, 2023 · 2 comments

Comments

@galund
Copy link
Contributor

galund commented Mar 8, 2023

Link in menu bar doesn't work because in Github pages we're not at the root of the domain. Might as well fix this even tho it will hopefully soon be moot.

@GDS-Dominic
Copy link
Contributor

Closing issue as not an issue with new theme

@galund
Copy link
Contributor Author

galund commented Nov 21, 2023

In the new theme, the we've lost some mandatory navigation elements ie this needs to work like all the other bits of documentation we have - see https://www.sign-in.service.gov.uk/documentation

So I think I'd better re-open this to cover some work in that area anyway, sorry!

I think we need

  • "GOV.UK One Login BETA" linking to https://www.sign-in.service.gov.uk/
  • "Vocabulary" with the blue highlight linking to our root page
  • bonus points if we can also link to other bits of the documentation (and then persuade them to link to us, once this is on the proper domain)

Doing the second point might resurrect the original bug unless we're careful, of course :/

@galund galund reopened this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants