From a01b703b1ecc7b971ed7ddab683fc90bb6b62851 Mon Sep 17 00:00:00 2001 From: Romain Bouqueau Date: Mon, 6 May 2024 11:46:13 -0400 Subject: [PATCH] comments about dasher intra-only --- src/filters/dasher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/filters/dasher.c b/src/filters/dasher.c index 9d55f02d19..5f70cf4276 100644 --- a/src/filters/dasher.c +++ b/src/filters/dasher.c @@ -6903,7 +6903,7 @@ static GF_Err dasher_setup_period(GF_Filter *filter, GF_DasherCtx *ctx, GF_DashS //not setup, create new AS ds->set = gf_mpd_adaptation_set_new(); ds->owns_set = GF_TRUE; - //only set hls intra for visual stream if we have know for sure + //only set hls intra for visual stream if we know for sure if ((ds->stream_type==GF_STREAM_VISUAL) && (ds->sync_points_type==DASHER_SYNC_NONE)) { ds->set->intra_only = GF_TRUE; } @@ -8947,7 +8947,7 @@ static GF_Err dasher_process(GF_Filter *filter) if (!sap_type && (ds->sync_points_type != DASHER_SYNC_PRESENT)) { ds->sync_points_type = DASHER_SYNC_PRESENT; - //cf setup_period: in sbound=0 mode, if stream has sync and non-sync and uses skip samples, allow spliting + //cf setup_period: in sbound=0 mode, if stream has sync and non-sync and uses skip samples, allow splitting //slightly before - typically needed for audio with sync points (usac, mpegh) where the segment duration is set //to the intra interval, we need to take into account the skip samples if (!ctx->sbound && !ds->cues