Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a buffer overflow issue in gf_sm_load_init () function, scene_manager.c
GF_Err gf_sm_load_init(GF_SceneLoader *load) { …… ext = (char *)strrchr(load->fileName, '.'); if (!ext) return GF_NOT_SUPPORTED; if (!stricmp(ext, ".gz")) { char *anext; ext[0] = 0; anext = (char *)strrchr(load->fileName, '.'); ext[0] = '.'; ext = anext; } strcpy(szExt, &ext[1]); // buffer overflow here. …… }
root@ubuntu:/opt/niugx/cov_product/gpac/gpac-master/bin/gcc# ./MP4Box -inctx inScene.exttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt -out output.txt -add overview.srt overview.mp4 Timed Text (SRT) import - text track 580 x 436, font Serif (size 18) *** stack smashing detected ***: ./MP4Box terminated Aborted (core dumped)
The text was updated successfully, but these errors were encountered:
fix some overflows due to strcpy
35ab447
fixes #1184, #1186, #1187 among other things
hi
this was fixed by the commit above
we won't be opening CVEs for gpac bugs but thanks for the reports anyway
Sorry, something went wrong.
this is CVE-2018-20761
Fixed.
Patch: 35ab447
No branches or pull requests
There is a buffer overflow issue in gf_sm_load_init () function, scene_manager.c
GF_Err gf_sm_load_init(GF_SceneLoader *load)
{
……
ext = (char *)strrchr(load->fileName, '.');
if (!ext) return GF_NOT_SUPPORTED;
if (!stricmp(ext, ".gz")) {
char *anext;
ext[0] = 0;
anext = (char *)strrchr(load->fileName, '.');
ext[0] = '.';
ext = anext;
}
strcpy(szExt, &ext[1]); // buffer overflow here.
……
}
root@ubuntu:/opt/niugx/cov_product/gpac/gpac-master/bin/gcc# ./MP4Box -inctx inScene.exttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt -out output.txt -add overview.srt overview.mp4
Timed Text (SRT) import - text track 580 x 436, font Serif (size 18)
*** stack smashing detected ***: ./MP4Box terminated
Aborted (core dumped)
The text was updated successfully, but these errors were encountered: