Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer overflow issue 3# #1186

Closed
niugx opened this issue Dec 22, 2018 · 3 comments
Closed

buffer overflow issue 3# #1186

niugx opened this issue Dec 22, 2018 · 3 comments

Comments

@niugx
Copy link

niugx commented Dec 22, 2018

There is a buffer overflow issue in gf_sm_load_init () function, scene_manager.c

GF_Err gf_sm_load_init(GF_SceneLoader *load)
{
……
ext = (char *)strrchr(load->fileName, '.');
if (!ext) return GF_NOT_SUPPORTED;
if (!stricmp(ext, ".gz")) {
char *anext;
ext[0] = 0;
anext = (char *)strrchr(load->fileName, '.');
ext[0] = '.';
ext = anext;
}
strcpy(szExt, &ext[1]); // buffer overflow here.
……
}

root@ubuntu:/opt/niugx/cov_product/gpac/gpac-master/bin/gcc# ./MP4Box -inctx inScene.exttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttttt -out output.txt -add overview.srt overview.mp4
Timed Text (SRT) import - text track 580 x 436, font Serif (size 18)
*** stack smashing detected ***: ./MP4Box terminated
Aborted (core dumped)

aureliendavid added a commit that referenced this issue Jan 11, 2019
@aureliendavid
Copy link
Member

hi

this was fixed by the commit above

we won't be opening CVEs for gpac bugs but thanks for the reports anyway

@niugx
Copy link
Author

niugx commented Feb 7, 2019

this is CVE-2018-20761

@niugx
Copy link
Author

niugx commented Apr 19, 2019

Fixed.

Patch:
35ab447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants