New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer overflow issue 4# #1187

Closed
niugx opened this Issue Dec 22, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@niugx
Copy link

niugx commented Dec 22, 2018

There is a buffer overflow issue in cat_multiple_files () function, fileimport.c

GF_Err cat_multiple_files(GF_ISOFile *dest, char *fileName, u32 import_flags, Double force_fps, u32 frames_per_sample, char *tmp_dir, Bool force_cat, Bool align_timelines, Bool allow_add_in_command)
{
……
if (sep) {
strcpy(cat_enum.szOpt, sep); // buffer overflow here.
sep[0] = 0;
}
……
}

root@ubuntu:/opt/niugx/cov_product/gpac/gpac-master/bin/gcc# ./MP4Box -cat cat*.txt:szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2szRad2 -add overview.srt overview.mp4
Timed Text (SRT) import - text track 580 x 436, font Serif (size 18)
Segmentation fault (core dumped)

If you indentify this issue as a vulnerability, please provide me with following information:
1.the affected versions.
2.patch
3.please assign a CVE-ID, discoverer is Guoxiang Niu, EaglEye Team

thank you

aureliendavid added a commit that referenced this issue Jan 11, 2019

@niugx

This comment has been minimized.

Copy link
Author

niugx commented Feb 7, 2019

this is CVE-2018-20762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment