Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEGV on unknown address on gf_list_count #1270

Closed
strongcourage opened this issue Jul 6, 2019 · 1 comment
Closed

SEGV on unknown address on gf_list_count #1270

strongcourage opened this issue Jul 6, 2019 · 1 comment

Comments

@strongcourage
Copy link

Hi,
Our fuzzer found an UAF on MP4Box (the latest commit 987169b on master).
PoC: https://github.com/strongcourage/PoCs/blob/master/gpac_987169b/PoC_segv_gf_list_count
Command: MP4Box -info $PoC
ASAN says:

==19963==ERROR: AddressSanitizer: SEGV on unknown address 0x00047fff8001 (pc 0x00000047a43d bp 0x60800000bfa0 sp 0x7ffe5b9765b0 T0)
    #0 0x47a43c in gf_list_count /home/dungnguyen/gueb-testing/gpac-head/src/utils/list.c:641
    #1 0x9809d4 in gf_m2ts_process_pmt /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/mpegts.c:2185
    #2 0x970944 in gf_m2ts_section_complete /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/mpegts.c:1610
    #3 0x971fa2 in gf_m2ts_gather_section /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/mpegts.c:1740
    #4 0x97991c in gf_m2ts_process_packet /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/mpegts.c:3446
    #5 0x97991c in gf_m2ts_process_data /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/mpegts.c:3507
    #6 0x986f65 in gf_m2ts_probe_file /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/mpegts.c:4641
    #7 0x963fa9 in gf_media_import /home/dungnguyen/gueb-testing/gpac-head/src/media_tools/media_import.c:10998
    #8 0x45b475 in convert_file_info /home/dungnguyen/gueb-testing/gpac-head/applications/mp4box/fileimport.c:124
    #9 0x43ac0c in mp4boxMain /home/dungnguyen/gueb-testing/gpac-head/applications/mp4box/main.c:4804
    #10 0x7ff2747fe82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #11 0x421eb8 in _start (/home/dungnguyen/PoCs/gpac_987169b/MP4Box-asan+0x421eb8)

Thanks,
Manh Dung

@jeanlf
Copy link
Member

jeanlf commented Jul 7, 2019

this was fixed after fixing #1266, #1267, #1268, #1269,

@jeanlf jeanlf closed this as completed Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants