Skip to content
This repository

Problem with FBDialog #32

Open
guidev opened this Issue · 5 comments

5 participants

Guglielmo Faglioni pavelshpak Barrett Jacobsen Ben Max David Gifford
Guglielmo Faglioni

When a FBDialog view is displayed by pressing a button in the actionsheet, the actionsheet does not dismiss correctly: the UI does not respond to touches.

pavelshpak

Can observe the same problem - I can tap through BlockAlert or BlockActionSheet and can't close/dismiss them.

Barrett Jacobsen
Collaborator

This may have been fixed by a previous commit, let me know if there are still issues as I don't use FBDialog.

Barrett Jacobsen barrettj closed this
Ben Max

This issue should stay open as I confirm it still persists. It's also fairly easy to reproduce. If you open a FBDialog from the alert's button block, the alert is dismissed (animation wise) but the screen is still dimmed and locked (UI unresponsive)

Barrett Jacobsen barrettj reopened this
Barrett Jacobsen
Collaborator

Reopened; but as none of the maintainers use FBDialog a fix from one of us is unlikely. We'll gladly welcome a pull--request that fixes the issue.

David Gifford

A pull request was submitted. The issue appears to be that the FBDialog class makes itself a child of the UIApplication.keywindow. When called within a blockaction, this FBDIalog view remains within the BlockBackground view hierarchy, and prevents the view from resigning its role as keywindow. The fix moves such views into the previous keywindow so that it can be restored.

This was a quicky fix - @barretj and others are probably more qualified than I to asses unintended consequences of this fix. But it works in my app tests.

Pull Request #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.