Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ARC Compatibility with Main Classes and Demo Project #21

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
6 participants
Collaborator

binarydev commented Apr 28, 2012

  • The project has had the core classes and accompanying demo project made compatible with ARC. It does not utilize any weak reference pointers, which should allow it to remain compatible with iOS 4.x+
  • Certain references that are used within blocks have been refactored to utilize variables with a local scope specifically for the purposes of the block, to allow more flexibility if need be, without adding extra overhead.

binarydev added some commits Apr 25, 2012

@binarydev binarydev Updated to be ARC Compatible
Removed all retains, releases, and autoreleases. Changed all retain
properties to strong.
1cd9f17
@binarydev binarydev Updated main project to utilize ARC
- Removed all retains and releases from the project overall
- Restructured example view controller to utilize an NSMutableArray to
maintain a strong pointer to the alerts and action sheets we created,
which would otherwise be deallocated, causing the app to crash
5b0e310
Collaborator

binarydev commented Apr 30, 2012

As a quick note, this was tested against the Apple LLVM 3.1 compiler, not the LLVM GCC 4.2

Owner

gpambrozio commented May 1, 2012

Thanks a lot for this. As the project is I can't pull this automatically, so I'll have to do it manually. I'll try to do it in a few weeks. In the meantime I'd suggest people use your branch for this.

In demo application, TextField in BlockTextPromptAlertView is not even showed and exception is thrown on button press.

MacMannes and others added some commits Nov 18, 2012

@MacMannes MacMannes AlertView and ActionSheet now retain self after showing + fixed showi…
…ng of UITextView in TextPromptAlertView
f9cdce8
@MacMannes MacMannes Fixes for iOS 6 849a450
@MacMannes MacMannes Create BlockAlertsAnd-ActionSheets.podspec dbb2f2c
@MacMannes MacMannes Update BlockAlertsAnd-ActionSheets.podspec c7fac6c
André Mathlener Added BlockPickerActionSheet 3798e26
André Mathlener Fixes for iOS < 6.x f2f2da6
@binarydev binarydev Merge pull request #1 from MacMannes/master
AlertView and ActionSheet now retain self after showing + fixed showing of UITextView in TextPromptAlertView, Added fixes for iOS6, Added BlockPickerActionSheet, Added cocoapods spec
4071c24
Collaborator

binarydev commented Mar 6, 2013

My branch has been updated to resolve a few retainment issues, as well as adding in iOS6 compatibility and the spec for cocoapods, with attribution of the source given back to Gustavo Ambrozio (thanks MacMannes!).

@binarydev binarydev was assigned Apr 9, 2013

@binarydev binarydev Merge pull request #2 from b051/master
Fixed your animation option enum usage.
c8388dc
Collaborator

barrettj commented Apr 30, 2013

Since you're now a contributor to the main repo - do we still need this pull request @binarydev - or can we remove it (to keep things cleaned up) knowing that you'll push your changes when you get a chance?

@barrettj barrettj referenced this pull request Apr 30, 2013

Closed

ARC Support #8

Collaborator

binarydev commented Apr 30, 2013

I have no objections to removing it to keep things cleaned up.

Thanks for checking,

Jose Santiago

On Apr 29, 2013, at 8:21 PM, Barrett Jacobsen notifications@github.com
wrote:

Since you're not a contributor to the main repo - do we still need this
pull request @binarydev https://github.com/binarydev - or can we remove
it (to keep things cleaned up) knowing that you'll push your changes when
you get a chance?


Reply to this email directly or view it on
GitHubhttps://github.com/gpambrozio/BlockAlertsAnd-ActionSheets/pull/21#issuecomment-17203008
.

@barrettj barrettj closed this Apr 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment