Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support auto rotation and auto resize for alert and action sheets #38

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants

siuying commented Jan 2, 2013

This patch add support of BlocksAlertsAnd-ActionSheets for different orientation and auto resize.

Instead of current approach that use UIWindow, this patch change the BlockBackground such that it is a UIView that is added to the first key window first subview.

siuying added some commits Jan 2, 2013

Make the BlockActionSheet and BlockAlertView rotate based on UIWindow…
… rotation

- instead of use a UIWindow, use a UIView as background, and add it as a subview of first subview of key window
- enable auto resize background
Owner

gpambrozio commented Jan 2, 2013

Does it still work when a keyboard is shown? The whole idea of using UIWindow is because of the keyboard.

Just tested and sadly there are issues with the text prompt.

tcunning commented Jan 3, 2013

Wouldn't the other issue with this approach be the nav bar wouldn't be covered by the alert view.

siuying commented Jan 3, 2013

@gpambrozio Yes, i can confirm this. It seems need to handle rotation with others way.

@siuying siuying closed this Jan 3, 2013

siuying commented Jan 3, 2013

@tcunning I was not aware there are already another PR (#36) on this. Look like it fullfill my needs already 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment