This commit implements a work around for a bug in 10.7 that was caused by a 10.7 64-bit ABI breaking change. Technically, this is not a bug in JSONKit, but with Mac OS X. When making changes to the ABI, it is (at least de facto) required to bump the "major version" of a shared library so that code designed around and built against the "guarantees" provided by previous versions ABI / API are not violated. Not only was this not done in 10.7, the ABI breaking change isn't even officially documented (to the best of my knowledge). It's certainly not mentioned in the 10.7 release notes.
…r Clang 3.0.
In the rare case when a hash collision occurs between two values, the object cache's bucket-probing code needs to go as far as comparing the bytes content of the candidate bucket with the bytes content of the current token. For numeric values, 'bytes' refers to the raw bytes of the number. These byte representations may contain leading '\0' values. strncmp() is only designed for comparing strings, so characters appearing after a '\0' are not compared. Therefore, if a hash collision occurs between two numeric values that only differ in their lower bytes, they will be assigned to the same bucket, and the cache will return the first token's object for the second token's value. memcmp() is binary-safe and considers all of the numbers' bytes, avoiding this problem. This is a rare case indeed, but here is an example that reproduces the problem: JSON Input: [ 1734.75, 417.75 ] Identical Types: double (8 bytes) Identical DJB Hashes: 2510392872 JSONKit (strncmp): [ 1734.75, 1734.75 ] (boo!) JSONKit (memcmp): [ 1734.75, 417.75 ] (yay!)
…some preprocessor-foo to JSONKit.m to check if JSONKit is being compiled with ARC / `-fobjc-arc` and #error if it is.
…able> constructions to the easier Markdown extra tables to see if the new github markdown processor accepts them. Also changed some <pre> items to ```objective-c / ``` fenced code style.
…meInitialization(). Missed the JSONDecoder +load stuff on the last commit. Related to issue #23.
, the code in the collection classes `+load` was removed and placed in a function with the `__attribute__ ((constructor))` attribute. This is to work around an apparent bug when building JSONKit as a static library for iOS targets. @ohhorob also opened a bug with apple- # 9461567.
…ry is implemented using a hash table that uses linear probing, the removal function needs to "re-add" items that follow the removed item so that linear probe hash collisions are not "lost". Closes #17
…n progress edits made it in to the commit. This change backs them out.
…ains no items (div by zero: (keyHash % dictionary->capacity))
… or Apache v2.0 license. This was motivated by the discussion at facebookarchive/three20#465
…sed a few from the last round
…ss formatting feature.
Minor change: When JKSerializeOptionPretty is enabled, JSONKit now sorts the keys. Major changes: The way that JSONKit implements the collection classes was modified. Specifically, JSONKit now follows the same strategy that the Cocoa collection classes use, which is to have a single subclass of the mutable collection class. This concrete subclass has an ivar bit that determines whether or not that instance is mutable, and when an immutable instance receives a mutating message, it throws an exception. The second change is a new feature. Normally, JSONKit can only serialize NSNull, NSNumber, NSString, NSArray, and NSDictioonary like objects. It is now possible to serialize an object of any class via either a delegate or a ^block. The delegate or ^block must return an object that can be serialized by JSONKit, however, otherwise JSONKit will fail to serialize the object. In other words, JSONKit tries to serialize an unsupported class of the object just once, and if the delegate or ^block returns another unsupported class, the second attempt to serialize will fail. In practice, this is not a problem at all, but it does prevent endless recursive attempts to serialize an unsupported class. This makes it trivial to serialize objects like NSDate or NSData. A NSDate object can be formatted using a NSDateFormatter to return a ISO-8601 'YYYY-MM-DDTHH:MM:SS.sssZ' type object, for example. Or a NSData object could be Base64 encoded. This greatly simplifies things when you have a complex, nested objects with objects that do not belong to the classes that JSONKit can serialize. It should be noted that the same caching that JSONKit does for the supported class types also applies to the objects of an unsupported class- if the same object is serialized more than once and the object is still in the serialization cache, JSONKit will copy the previous serialization result instead of invoking the delegate or ^block again. Therefore, you should not expect or depend on your delegate or block being called each time the same object needs to be serialized AND the delegate or block MUST return a "formatted object" that is STRICTLY invariant (that is to say the same object must always return the exact same formatted output).