New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change event handlers arguments signature #256

Closed
gpbl opened this Issue Feb 14, 2017 · 0 comments

Comments

1 participant
@gpbl
Owner

gpbl commented Feb 14, 2017

The current event handlers such as onDayClick have a signature which puts the Synthetic Event as first argument:

onDayClick={ (e, day, modifiers) => doSomething(day); }

however it is expected the most common arguments to be day and modifiers:

onDayClick={ (day, modifiers, e) => doSomething(day); }

which can lead to a more concise, readable code:

onDayClick={ doSomething }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment