New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevButton and nextButton should have text or aria-label #258

Closed
helgefredheim opened this Issue Feb 16, 2017 · 3 comments

Comments

2 participants
@helgefredheim

helgefredheim commented Feb 16, 2017

Great component!

An issue after having tested accessibility with a blind person: The previous and next buttons should have aria-label="Previous | Next" (localizeable) or a text:

<span role="button" {...}>Previous</span>

This is due to screen reader accessibility. Without the aria-label or text, the button is read as something weird.

@gpbl gpbl added the a11y label Feb 16, 2017

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Feb 16, 2017

Owner

Thanks for the report! This will be added soon. Meanwhile, you can create your own navbar:

http://react-day-picker.js.org/examples/?customElements

Owner

gpbl commented Feb 16, 2017

Thanks for the report! This will be added soon. Meanwhile, you can create your own navbar:

http://react-day-picker.js.org/examples/?customElements

@helgefredheim

This comment has been minimized.

Show comment
Hide comment
@helgefredheim

helgefredheim Feb 21, 2017

So I did, thank you!

helgefredheim commented Feb 21, 2017

So I did, thank you!

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Mar 3, 2017

Owner

Published as v5.1.1. Check the new labels prop!

Owner

gpbl commented Mar 3, 2017

Published as v5.1.1. Check the new labels prop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment