New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the disabled Nav Buttons when fromMonth or toMonth props is specified #366

Closed
aniruddhashevle opened this Issue May 25, 2017 · 3 comments

Comments

2 participants
@aniruddhashevle
Contributor

aniruddhashevle commented May 25, 2017

Basically if we add fromMonth or toMonth props then the nav buttons (which are used to navigate next or previous months) are not displayed for the months that are defined in fromMonth or toMonth props.

This is working properly.

However, it'd be better if there is a choice to show those Nav Buttons even for the months that are defined in fromMonth or toMonth props and those should be disabled for the respective months.

For this I've made the changes accordingly and I'm sending the pull request.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl May 25, 2017

Owner

This is a good idea, I'd hide them via CSS (e.g. by setting an --interactionDisabled suffix to the button). It would be a breaking change, tough :(

Owner

gpbl commented May 25, 2017

This is a good idea, I'd hide them via CSS (e.g. by setting an --interactionDisabled suffix to the button). It would be a breaking change, tough :(

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 29, 2017

@gpbl @aniruddhashevle I think we should not remove the navigation html structure if it is disabled, so that user can set arrow image for disabled. or setting the class will also work.

ghost commented May 29, 2017

@gpbl @aniruddhashevle I think we should not remove the navigation html structure if it is disabled, so that user can set arrow image for disabled. or setting the class will also work.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 17, 2017

Owner

Thanks @aniruddhashevle for your contribution! It has been published in v6.0.0 (changelog) 🎉

Owner

gpbl commented Jun 17, 2017

Thanks @aniruddhashevle for your contribution! It has been published in v6.0.0 (changelog) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment