New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With multiple calendars, navigation actions skip 'numberOfMonths' #37

Closed
anton-kabysh opened this Issue Jul 29, 2015 · 2 comments

Comments

2 participants
@anton-kabysh

anton-kabysh commented Jul 29, 2015

For example, if numberOfMonths=2, and initialMonth is 'June'. Navigating through calendar with next/prev month show only pair of mounts ['June', 'July'], ['August', 'Sept'], ['Oct', 'Nov'] and etc. But not ['July', 'Aug'] or ['May', 'June'].

Try navigation at http://www.gpbl.org/react-day-picker/ Range of days example.

@gpbl gpbl added bug:minor and removed bug:minor labels Jul 29, 2015

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jul 29, 2015

Owner

@anton-kabysh yeah thanks there was a reason for this, but I don't remember why :0

Owner

gpbl commented Jul 29, 2015

@anton-kabysh yeah thanks there was a reason for this, but I don't remember why :0

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jul 29, 2015

Owner

I guess I intended the nav buttons as a way to change the whole view, so you should effectively jump between months as specified in numberOfMonths. I'm trying the behavior you are suggesting and I agree it seems more consistent. However, when using the arrow keys to navigate between the days, it should add 2 months instead of one.

Owner

gpbl commented Jul 29, 2015

I guess I intended the nav buttons as a way to change the whole view, so you should effectively jump between months as specified in numberOfMonths. I'm trying the behavior you are suggesting and I agree it seems more consistent. However, when using the arrow keys to navigate between the days, it should add 2 months instead of one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment