-
-
Notifications
You must be signed in to change notification settings - Fork 766
Closed
Milestone
Description
Analyzing #374 I've found we can optimize the re-rending of the components by using shouldComponentUpdate or PureComponent.
-
Captioncomponent – should be usingshouldComponentUpdateto avoid useless re-rendering. Should update only iflocaleanddate's year/month change. -
NavBarcomponent – can extendPureComponent -
Weekdaycomponent – can extendPureComponent -
Weekdayscomponent – can extendPureComponent -
Daycomponent – should be usingshouldComponentUpdateto avoid useless re-rendering. Should update only if the day's modifiers change.
The Month component uses its child as function to render Day, this is a weird pattern and makes optimization harder:
- move
renderDayInMonthandrenderDaymethod fromDayPickertoMonth -
Monthcomponent should be usingshouldComponentUpdateto avoid useless re-rendering. Should update if modifiers change.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels