New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Day by Deleting Input #423

Closed
maxsalven opened this Issue Jun 22, 2017 · 2 comments

Comments

2 participants
@maxsalven

maxsalven commented Jun 22, 2017

Similar to clickUnselectsDay, it would be great to have a deleteUnselectsDay on the DayPickerInput.

I.e. if the user deletes the content of the input field, and then blurs it, we call onDayChange(undefined).

Right now it's not super clear from a UI perspective that you have to click on a selected date to unselect it. I've seen my users trying to delete the text in the input box instead.

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 22, 2017

Owner

Definitely a bug! I recall to have implemented this behavior then removed it for some obscure reason :)

Meanwhile, you should be able to workaround this by adding the onChange prop, which behaves like the regular input's prop.

Thanks for the feedback 🙏🏽

Owner

gpbl commented Jun 22, 2017

Definitely a bug! I recall to have implemented this behavior then removed it for some obscure reason :)

Meanwhile, you should be able to workaround this by adding the onChange prop, which behaves like the regular input's prop.

Thanks for the feedback 🙏🏽

@gpbl

This comment has been minimized.

Show comment
Hide comment
@gpbl

gpbl Jun 22, 2017

Owner

Fixed in v6.0.3

Owner

gpbl commented Jun 22, 2017

Fixed in v6.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment